Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing qualifier for cuda namespace #2940

Merged
merged 1 commit into from
Nov 23, 2024
Merged

Add missing qualifier for cuda namespace #2940

merged 1 commit into from
Nov 23, 2024

Conversation

bernhardmgruber
Copy link
Contributor

Fixes: #2939

@bernhardmgruber bernhardmgruber requested review from a team as code owners November 22, 2024 20:51
@github-actions GitHub Actions
Copy link
Contributor

🟩 CI finished in 1h 12m: Pass: 100%/224 | Total: 1d 03h | Avg: 7m 29s | Max: 35m 28s | Hits: 98%/12288

  • 🟩 thrust: Pass: 100%/111 | Total: 12h 19m | Avg: 6m 39s | Max: 35m 28s | Hits: 99%/9260 

    🟩 cmake_options
  🟩 -DTHRUST_DISPATCH_TYPE=Force32bit Pass: 100%/2   | Total: 18m 22s | Avg:  9m 11s | Max: 12m 29s
🟩 cpu
  🟩 amd64              Pass: 100%/103 | Total: 11h 42m | Avg:  6m 49s | Max: 35m 28s | Hits:  99%/9260  
  🟩 arm64              Pass: 100%/8   | Total: 37m 14s | Avg:  4m 39s | Max:  5m 05s
🟩 ctk
  🟩 11.1               Pass: 100%/15  | Total:  1h 17m | Avg:  5m 11s | Max: 18m 25s | Hits:  99%/1852  
  🟩 11.8               Pass: 100%/3   | Total: 16m 02s | Avg:  5m 20s | Max:  5m 34s
  🟩 12.5               Pass: 100%/4   | Total:  1h 00m | Avg: 15m 14s | Max: 15m 57s
  🟩 12.6               Pass: 100%/89  | Total:  9h 44m | Avg:  6m 34s | Max: 35m 28s | Hits:  99%/7408  
🟩 cudacxx
  🟩 ClangCUDA18        Pass: 100%/4   | Total: 20m 01s | Avg:  5m 00s | Max:  5m 20s
  🟩 nvcc11.1           Pass: 100%/15  | Total:  1h 17m | Avg:  5m 11s | Max: 18m 25s | Hits:  99%/1852  
  🟩 nvcc11.8           Pass: 100%/3   | Total: 16m 02s | Avg:  5m 20s | Max:  5m 34s
  🟩 nvcc12.5           Pass: 100%/4   | Total:  1h 00m | Avg: 15m 14s | Max: 15m 57s
  🟩 nvcc12.6           Pass: 100%/85  | Total:  9h 24m | Avg:  6m 38s | Max: 35m 28s | Hits:  99%/7408  
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/4   | Total: 20m 01s | Avg:  5m 00s | Max:  5m 20s
  🟩 nvcc               Pass: 100%/107 | Total: 11h 59m | Avg:  6m 43s | Max: 35m 28s | Hits:  99%/9260  
🟩 cxx
  🟩 Clang9             Pass: 100%/6   | Total: 31m 40s | Avg:  5m 16s | Max:  6m 07s
  🟩 Clang10            Pass: 100%/3   | Total: 18m 27s | Avg:  6m 09s | Max:  6m 38s
  🟩 Clang11            Pass: 100%/4   | Total: 20m 20s | Avg:  5m 05s | Max:  5m 08s
  🟩 Clang12            Pass: 100%/4   | Total: 19m 36s | Avg:  4m 54s | Max:  5m 12s
  🟩 Clang13            Pass: 100%/4   | Total: 19m 49s | Avg:  4m 57s | Max:  5m 21s
  🟩 Clang14            Pass: 100%/4   | Total: 21m 28s | Avg:  5m 22s | Max:  5m 36s
  🟩 Clang15            Pass: 100%/4   | Total: 21m 22s | Avg:  5m 20s | Max:  5m 51s
  🟩 Clang16            Pass: 100%/4   | Total: 21m 22s | Avg:  5m 20s | Max:  5m 46s
  🟩 Clang17            Pass: 100%/4   | Total: 20m 58s | Avg:  5m 14s | Max:  5m 46s
  🟩 Clang18            Pass: 100%/11  | Total:  1h 02m | Avg:  5m 42s | Max: 11m 36s
  🟩 GCC6               Pass: 100%/2   | Total:  8m 10s | Avg:  4m 05s | Max:  4m 24s
  🟩 GCC7               Pass: 100%/6   | Total: 26m 31s | Avg:  4m 25s | Max:  5m 32s
  🟩 GCC8               Pass: 100%/6   | Total: 58m 36s | Avg:  9m 46s | Max: 35m 28s
  🟩 GCC9               Pass: 100%/6   | Total: 27m 38s | Avg:  4m 36s | Max:  5m 15s
  🟩 GCC10              Pass: 100%/4   | Total: 20m 31s | Avg:  5m 07s | Max:  5m 27s
  🟩 GCC11              Pass: 100%/7   | Total: 38m 49s | Avg:  5m 32s | Max:  6m 12s
  🟩 GCC12              Pass: 100%/4   | Total: 22m 16s | Avg:  5m 34s | Max:  6m 04s
  🟩 GCC13              Pass: 100%/16  | Total:  1h 49m | Avg:  6m 50s | Max: 13m 53s
  🟩 Intel2023.2.0      Pass: 100%/3   | Total: 20m 28s | Avg:  6m 49s | Max:  7m 12s
  🟩 MSVC14.16          Pass: 100%/1   | Total: 18m 25s | Avg: 18m 25s | Max: 18m 25s | Hits:  99%/1852  
  🟩 MSVC14.29          Pass: 100%/2   | Total: 31m 29s | Avg: 15m 44s | Max: 16m 48s | Hits:  99%/3704  
  🟩 MSVC14.39          Pass: 100%/2   | Total: 38m 38s | Avg: 19m 19s | Max: 21m 28s | Hits:  99%/3704  
  🟩 NVHPC24.7          Pass: 100%/4   | Total:  1h 00m | Avg: 15m 14s | Max: 15m 57s
🟩 cxx_family
  🟩 Clang              Pass: 100%/48  | Total:  4h 17m | Avg:  5m 22s | Max: 11m 36s
  🟩 GCC                Pass: 100%/51  | Total:  5h 11m | Avg:  6m 07s | Max: 35m 28s
  🟩 Intel              Pass: 100%/3   | Total: 20m 28s | Avg:  6m 49s | Max:  7m 12s
  🟩 MSVC               Pass: 100%/5   | Total:  1h 28m | Avg: 17m 42s | Max: 21m 28s | Hits:  99%/9260  
  🟩 NVHPC              Pass: 100%/4   | Total:  1h 00m | Avg: 15m 14s | Max: 15m 57s
🟩 gpu
  🟩 v100               Pass: 100%/111 | Total: 12h 19m | Avg:  6m 39s | Max: 35m 28s | Hits:  99%/9260  
🟩 jobs
  🟩 Build              Pass: 100%/103 | Total: 10h 44m | Avg:  6m 15s | Max: 35m 28s | Hits:  99%/7408  
  🟩 TestCPU            Pass: 100%/4   | Total: 44m 19s | Avg: 11m 04s | Max: 21m 28s | Hits:  99%/1852  
  🟩 TestGPU            Pass: 100%/4   | Total: 50m 42s | Avg: 12m 40s | Max: 13m 53s
🟩 sm
  🟩 60;70;80;90        Pass: 100%/3   | Total: 16m 02s | Avg:  5m 20s | Max:  5m 34s
  🟩 90a                Pass: 100%/4   | Total: 18m 10s | Avg:  4m 32s | Max:  4m 55s
🟩 std
  🟩 11                 Pass: 100%/30  | Total:  2h 41m | Avg:  5m 22s | Max: 14m 12s
  🟩 14                 Pass: 100%/29  | Total:  3h 32m | Avg:  7m 19s | Max: 35m 28s | Hits:  99%/3704  
  🟩 17                 Pass: 100%/27  | Total:  2h 46m | Avg:  6m 10s | Max: 16m 48s | Hits:  99%/1852  
  🟩 20                 Pass: 100%/23  | Total:  3h 00m | Avg:  7m 51s | Max: 21m 28s | Hits:  99%/3704

  • 🟩 cub: Pass: 100%/110 | Total: 15h 11m | Avg: 8m 17s | Max: 24m 34s | Hits: 97%/3028 

    🟩 cpu
  🟩 amd64              Pass: 100%/102 | Total: 14h 15m | Avg:  8m 23s | Max: 24m 34s | Hits:  97%/3028  
  🟩 arm64              Pass: 100%/8   | Total: 56m 22s | Avg:  7m 02s | Max:  7m 35s
🟩 ctk
  🟩 11.1               Pass: 100%/15  | Total:  1h 44m | Avg:  6m 58s | Max: 16m 42s | Hits:  97%/757   
  🟩 11.8               Pass: 100%/3   | Total: 25m 46s | Avg:  8m 35s | Max:  9m 30s
  🟩 12.5               Pass: 100%/4   | Total: 45m 23s | Avg: 11m 20s | Max: 11m 34s
  🟩 12.6               Pass: 100%/88  | Total: 12h 15m | Avg:  8m 21s | Max: 24m 34s | Hits:  97%/2271  
🟩 cudacxx
  🟩 ClangCUDA18        Pass: 100%/4   | Total: 21m 31s | Avg:  5m 22s | Max:  5m 53s
  🟩 nvcc11.1           Pass: 100%/15  | Total:  1h 44m | Avg:  6m 58s | Max: 16m 42s | Hits:  97%/757   
  🟩 nvcc11.8           Pass: 100%/3   | Total: 25m 46s | Avg:  8m 35s | Max:  9m 30s
  🟩 nvcc12.5           Pass: 100%/4   | Total: 45m 23s | Avg: 11m 20s | Max: 11m 34s
  🟩 nvcc12.6           Pass: 100%/84  | Total: 11h 54m | Avg:  8m 30s | Max: 24m 34s | Hits:  97%/2271  
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/4   | Total: 21m 31s | Avg:  5m 22s | Max:  5m 53s
  🟩 nvcc               Pass: 100%/106 | Total: 14h 50m | Avg:  8m 23s | Max: 24m 34s | Hits:  97%/3028  
🟩 cxx
  🟩 Clang9             Pass: 100%/6   | Total: 42m 45s | Avg:  7m 07s | Max:  7m 50s
  🟩 Clang10            Pass: 100%/3   | Total: 23m 47s | Avg:  7m 55s | Max:  8m 33s
  🟩 Clang11            Pass: 100%/4   | Total: 26m 14s | Avg:  6m 33s | Max:  6m 59s
  🟩 Clang12            Pass: 100%/4   | Total: 26m 52s | Avg:  6m 43s | Max:  7m 08s
  🟩 Clang13            Pass: 100%/4   | Total: 26m 44s | Avg:  6m 41s | Max:  7m 33s
  🟩 Clang14            Pass: 100%/4   | Total: 27m 50s | Avg:  6m 57s | Max:  7m 34s
  🟩 Clang15            Pass: 100%/4   | Total: 26m 40s | Avg:  6m 40s | Max:  6m 59s
  🟩 Clang16            Pass: 100%/4   | Total: 27m 32s | Avg:  6m 53s | Max:  7m 18s
  🟩 Clang17            Pass: 100%/4   | Total: 27m 02s | Avg:  6m 45s | Max:  7m 37s
  🟩 Clang18            Pass: 100%/11  | Total:  1h 36m | Avg:  8m 45s | Max: 21m 01s
  🟩 GCC6               Pass: 100%/2   | Total: 12m 34s | Avg:  6m 17s | Max:  6m 24s
  🟩 GCC7               Pass: 100%/6   | Total: 39m 10s | Avg:  6m 31s | Max:  7m 28s
  🟩 GCC8               Pass: 100%/6   | Total: 38m 58s | Avg:  6m 29s | Max:  7m 20s
  🟩 GCC9               Pass: 100%/6   | Total: 39m 46s | Avg:  6m 37s | Max:  7m 16s
  🟩 GCC10              Pass: 100%/4   | Total: 27m 24s | Avg:  6m 51s | Max:  7m 04s
  🟩 GCC11              Pass: 100%/7   | Total: 53m 13s | Avg:  7m 36s | Max:  9m 30s
  🟩 GCC12              Pass: 100%/4   | Total: 29m 05s | Avg:  7m 16s | Max:  7m 26s
  🟩 GCC13              Pass: 100%/16  | Total:  3h 07m | Avg: 11m 44s | Max: 24m 34s
  🟩 Intel2023.2.0      Pass: 100%/3   | Total: 25m 29s | Avg:  8m 29s | Max:  8m 47s
  🟩 MSVC14.16          Pass: 100%/1   | Total: 16m 42s | Avg: 16m 42s | Max: 16m 42s | Hits:  97%/757   
  🟩 MSVC14.29          Pass: 100%/2   | Total: 29m 30s | Avg: 14m 45s | Max: 15m 15s | Hits:  97%/1514  
  🟩 MSVC14.39          Pass: 100%/1   | Total: 14m 43s | Avg: 14m 43s | Max: 14m 43s | Hits:  97%/757   
  🟩 NVHPC24.7          Pass: 100%/4   | Total: 45m 23s | Avg: 11m 20s | Max: 11m 34s
🟩 cxx_family
  🟩 Clang              Pass: 100%/48  | Total:  5h 51m | Avg:  7m 19s | Max: 21m 01s
  🟩 GCC                Pass: 100%/51  | Total:  7h 08m | Avg:  8m 23s | Max: 24m 34s
  🟩 Intel              Pass: 100%/3   | Total: 25m 29s | Avg:  8m 29s | Max:  8m 47s
  🟩 MSVC               Pass: 100%/4   | Total:  1h 00m | Avg: 15m 13s | Max: 16m 42s | Hits:  97%/3028  
  🟩 NVHPC              Pass: 100%/4   | Total: 45m 23s | Avg: 11m 20s | Max: 11m 34s
🟩 gpu
  🟩 v100               Pass: 100%/110 | Total: 15h 11m | Avg:  8m 17s | Max: 24m 34s | Hits:  97%/3028  
🟩 jobs
  🟩 Build              Pass: 100%/102 | Total: 12h 24m | Avg:  7m 18s | Max: 16m 42s | Hits:  97%/3028  
  🟩 DeviceLaunch       Pass: 100%/1   | Total: 20m 55s | Avg: 20m 55s | Max: 20m 55s
  🟩 GraphCapture       Pass: 100%/1   | Total: 18m 12s | Avg: 18m 12s | Max: 18m 12s
  🟩 HostLaunch         Pass: 100%/3   | Total: 57m 39s | Avg: 19m 13s | Max: 20m 10s
  🟩 TestGPU            Pass: 100%/3   | Total:  1h 10m | Avg: 23m 21s | Max: 24m 34s
🟩 sm
  🟩 60;70;80;90        Pass: 100%/3   | Total: 25m 46s | Avg:  8m 35s | Max:  9m 30s
  🟩 90a                Pass: 100%/4   | Total: 19m 00s | Avg:  4m 45s | Max:  4m 55s
🟩 std
  🟩 11                 Pass: 100%/30  | Total:  4h 02m | Avg:  8m 04s | Max: 24m 28s
  🟩 14                 Pass: 100%/29  | Total:  3h 50m | Avg:  7m 57s | Max: 16m 42s | Hits:  97%/1514  
  🟩 17                 Pass: 100%/27  | Total:  3h 07m | Avg:  6m 57s | Max: 14m 15s | Hits:  97%/757   
  🟩 20                 Pass: 100%/24  | Total:  4h 11m | Avg: 10m 27s | Max: 24m 34s | Hits:  97%/757

  • 🟩 cccl_c_parallel: Pass: 100%/2 | Total: 9m 32s | Avg: 4m 46s | Max: 7m 32s

     
    🟩 cpu
  🟩 amd64              Pass: 100%/2   | Total:  9m 32s | Avg:  4m 46s | Max:  7m 32s
🟩 ctk
  🟩 12.6               Pass: 100%/2   | Total:  9m 32s | Avg:  4m 46s | Max:  7m 32s
🟩 cudacxx
  🟩 nvcc12.6           Pass: 100%/2   | Total:  9m 32s | Avg:  4m 46s | Max:  7m 32s
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/2   | Total:  9m 32s | Avg:  4m 46s | Max:  7m 32s
🟩 cxx
  🟩 GCC13              Pass: 100%/2   | Total:  9m 32s | Avg:  4m 46s | Max:  7m 32s
🟩 cxx_family
  🟩 GCC                Pass: 100%/2   | Total:  9m 32s | Avg:  4m 46s | Max:  7m 32s
🟩 gpu
  🟩 v100               Pass: 100%/2   | Total:  9m 32s | Avg:  4m 46s | Max:  7m 32s
🟩 jobs
  🟩 Build              Pass: 100%/1   | Total:  2m 00s | Avg:  2m 00s | Max:  2m 00s
  🟩 Test               Pass: 100%/1   | Total:  7m 32s | Avg:  7m 32s | Max:  7m 32s

  • 🟩 python: Pass: 100%/1 | Total: 17m 12s | Avg: 17m 12s | Max: 17m 12s

     
    🟩 cpu
  🟩 amd64              Pass: 100%/1   | Total: 17m 12s | Avg: 17m 12s | Max: 17m 12s
🟩 ctk
  🟩 12.6               Pass: 100%/1   | Total: 17m 12s | Avg: 17m 12s | Max: 17m 12s
🟩 cudacxx
  🟩 nvcc12.6           Pass: 100%/1   | Total: 17m 12s | Avg: 17m 12s | Max: 17m 12s
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/1   | Total: 17m 12s | Avg: 17m 12s | Max: 17m 12s
🟩 cxx
  🟩 GCC13              Pass: 100%/1   | Total: 17m 12s | Avg: 17m 12s | Max: 17m 12s
🟩 cxx_family
  🟩 GCC                Pass: 100%/1   | Total: 17m 12s | Avg: 17m 12s | Max: 17m 12s
🟩 gpu
  🟩 v100               Pass: 100%/1   | Total: 17m 12s | Avg: 17m 12s | Max: 17m 12s
🟩 jobs
  🟩 Test               Pass: 100%/1   | Total: 17m 12s | Avg: 17m 12s | Max: 17m 12s

👃 Inspect Changes

Modifications in project?

Project
CCCL Infrastructure
libcu++
+/- CUB
Thrust
CUDA Experimental
python
CCCL C Parallel Library
Catch2Helper

Modifications in project or dependencies?

Project
CCCL Infrastructure
libcu++
+/- CUB
+/- Thrust
CUDA Experimental
+/- python
+/- CCCL C Parallel Library
+/- Catch2Helper

🏃‍ Runner counts (total jobs: 224)
# Runner
185 linux-amd64-cpu16
16 linux-arm64-cpu16
14 linux-amd64-gpu-v100-latest-1
9 windows-amd64-cpu16

@bernhardmgruber bernhardmgruber merged commit 537b050 into NVIDIA:main Nov 23, 2024
241 checks passed
@bernhardmgruber bernhardmgruber deleted the fix_cuda_ns branch November 23, 2024 08:04
davebayer pushed a commit to davebayer/cccl that referenced this pull request Nov 25, 2024
@bernhardmgruber @davebayer
Add missing qualifier for cuda namespace (NVIDIA#2940)
ef9ae72 
Fixes: NVIDIA#2939
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pciolkosz pciolkosz pciolkosz approved these changes

@elstehle elstehle Awaiting requested review from elstehle elstehle is a code owner automatically assigned from NVIDIA/cccl-cub-codeowners

@alliepiper alliepiper Awaiting requested review from alliepiper alliepiper is a code owner automatically assigned from NVIDIA/cccl-codeowners

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ambiguous cuda:: namespace issue
2 participants
@bernhardmgruber @pciolkosz