Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unlisted distributions #62

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

elezar
Copy link
Member

@elezar elezar commented May 17, 2024

No description provided.

@elezar elezar requested a review from mikemckiernan May 17, 2024 14:38
@elezar elezar self-assigned this May 17, 2024
Copy link
Member

@mikemckiernan mikemckiernan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updates appear to increase the scope of support and that's counter to my instincts--but you must have your reasons. PLMK what I can clarify and thank you.

@@ -16,7 +16,12 @@ backlinks: none

## Linux Distributions

Supported Linux distributions are listed below:
The NVIDIA Container Toolkit has been qualified against the following platforms.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect your choice of "qualified" rather than supported is to communicate some subtlety. If feels dicey to me, but it's you who answers questions and not me.

nit: s/has been/is/, unless there is a consideration that I'm overlooking.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue is that people reach out to us all the time pointing out that we need to add "Debian 12" support or "Ubuntu 24.04" support, where we are reasonably confident that the packages should work as is. The caveat is that we have not officiallty tested against these configurations. If you have a suggestion on how to better call this out, that would be appreciated.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines +21 to +24
Note that the installation packages are generally forward-compatible and the
omission of newer distributions from this list below does not indicate that the
NVIDIA Container Toolkit cannot be used there. Specific issues with newer
distributions should be reported.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be rephrased more concisely.

NVIDIA Container Toolkit is generally forward compatible and works successfully on newer versions of the operating systems in the following table.

I've puzzled through the thought of directing readers to report issues from this section of the text, and I can't think why it's more compelling to urge that action here than in any other section. If you prefer to keep it, consider something like "Open an issue in the toolkit repository to report problems."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants