Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add py313 builds #272

Merged
merged 2 commits into from
Dec 8, 2024
Merged

Add py313 builds #272

merged 2 commits into from
Dec 8, 2024

Conversation

leofang
Copy link
Member

@leofang leofang commented Dec 6, 2024 •
edited
Loading

Blocked by #267.

xref: #131 (comment)

@leofang leofang added P0 High priority - Must do! CI/CD CI/CD infrastructure labels Dec 6, 2024
@copy-pr-bot copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Dec 6, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@leofang
Copy link
Member Author

leofang commented Dec 6, 2024

/ok to test

@leofang
Copy link
Member Author

leofang commented Dec 6, 2024

Looks like everything builds fine (after a few retries, due to #271).

@leofang leofang added this to the cuda-python 12-next, 11-next milestone Dec 6, 2024
@leofang leofang changed the title WIP: Add py313 builds Add py313 builds Dec 6, 2024
@leofang leofang marked this pull request as ready for review December 6, 2024 21:47
@leofang
Copy link
Member Author

leofang commented Dec 6, 2024

/ok to test

@leofang
Copy link
Member Author

leofang commented Dec 6, 2024

@ksimpson-work thanks for the earlier suggestion, this PR is now very clean (one-liner, as expected) 🙂

@leofang leofang self-assigned this Dec 6, 2024
@leofang leofang added cuda.bindings Everything related to the cuda.bindings module cuda.core Everything related to the cuda.core module labels Dec 6, 2024
ksimpson-work
ksimpson-work approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@ksimpson-work ksimpson-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks !

@leofang leofang marked this pull request as draft December 8, 2024 05:35
@leofang leofang marked this pull request as ready for review December 8, 2024 23:47
@leofang
Copy link
Member Author

leofang commented Dec 8, 2024

The test CI has been merged (#124). Let's get this actually tested in the CI.

@leofang
Copy link
Member Author

leofang commented Dec 8, 2024

/ok to test

@leofang
Copy link
Member Author

leofang commented Dec 8, 2024

All is green, let's merge!

@leofang leofang merged commit 1ff0b3e into NVIDIA:main Dec 8, 2024
30 checks passed
@leofang leofang deleted the py313 branch December 8, 2024 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksimpson-work ksimpson-work ksimpson-work approved these changes

@vzhurba01 vzhurba01 Awaiting requested review from vzhurba01

Assignees

@leofang leofang

Labels
CI/CD CI/CD infrastructure cuda.bindings Everything related to the cuda.bindings module cuda.core Everything related to the cuda.core module P0 High priority - Must do!
Projects
None yet
Milestone
cuda-python 12.8.0 & 11.8.6
Development

Successfully merging this pull request may close these issues.
2 participants
@leofang @ksimpson-work