handle CTK version specific options in the linker test #371
+10
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksimpson-work
added
P1
|
/ok to test |
|
/ok to test |
leofang
reviewed
Jan 15, 2025
leofang
reviewed
Jan 15, 2025
leofang
reviewed
Jan 15, 2025
|
/ok to test |
|
/ok to test |
|
/ok to test |
|
/ok to test |
|
|
I looked. I'll ping @ksimpson-work to chat 1:1. |
ksimpson-work
commented
Jan 17, 2025
ksimpson-work
commented
Jan 17, 2025
… into handle-version-specific-options
ksimpson-work
changed the title
|
/ok to test |
… into handle-version-specific-options
|
/ok to test |
leofang
reviewed
Jan 23, 2025
|
/ok to test |
rwgk
previously approved these changes
Jan 28, 2025
| ] | ||
| if not culink_backend: |
There was a problem hiding this comment.
Suggested for line 22 above:
if culink_backend:
nvjitlink = None
else:
from cuda.bindings import nvjitlink
Then here:
if nvjitlink is not None:
That way the import appears only once, and near the top, where it is more expected.
cuda_core/tests/test_linker.py
Outdated
| @@ -2,6 +2,7 @@ | |||
| # | |||
| # SPDX-License-Identifier: LicenseRef-NVIDIA-SOFTWARE-LICENSE | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Delete the extra empty line again?
|
/ok to test |
rwgk
approved these changes
Jan 28, 2025
|
/ok to test |
|
/ok to test |
1 similar comment
|
/ok to test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change skips tests when a specific nvjitlink exception is raised for invalid option, which happens if the option is invalid, or if the option is invalid for the given CTK.
I think we should also add cuda 12.4 to the test matrix because <21.3 targets the culink backend, and cuda 12.6 has options which aren't part of 12.4