Fix Photonics `get_state` #2243

Omar-ORCA · 2024-10-02T12:54:32Z

Fixes get_state of the photonics simulator

copy-pr-bot · 2024-10-02T12:54:41Z

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

docs/sphinx/examples/cpp/providers/photonics_tbi_get_state.cpp

docs/sphinx/examples/cpp/providers/photonics_tbi_sample.cpp

khalatepradnya · 2024-10-03T22:58:17Z

Command Bot: Processing...

runtime/cudaq/qis/managers/photonics/PhotonicsExecutionManager.cpp

runtime/cudaq/qis/managers/photonics/photonics_qis.h

khalatepradnya · 2024-10-04T15:36:20Z

Command Bot: Processing...

runtime/nvqir/photonics/PhotonicCircuitSimulator.h

khalatepradnya · 2024-10-04T23:22:20Z

Command Bot: Processing...

khalatepradnya · 2024-10-07T15:06:40Z

Command Bot: Processing...

khalatepradnya · 2024-10-08T05:04:52Z

Command Bot: Processing...

khalatepradnya · 2024-10-08T15:04:34Z

Command Bot: Processing...

runtime/cudaq/cudaq.cpp

khalatepradnya · 2024-10-08T22:06:09Z

Command Bot: Processing...

github-actions · 2024-10-08T23:27:41Z

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

khalatepradnya · 2024-10-09T14:44:06Z

Command Bot: Processing...

github-actions · 2024-10-09T15:39:08Z

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

docs/sphinx/examples/cpp/providers/photonics_tbi_get_state.cpp

runtime/nvqir/photonics/PhotonicGates.h

amccaskey · 2024-10-09T16:27:10Z

One big question I have is what does the PhotonicsCircuitSimulator add beyond what is in CircuitSimulator? I wonder if you could craft a CircuitSimulator subtype that does what you need? I would have thought so if you craft the execution manager to only use the applyCustomUnitary operation.

khalatepradnya · 2024-10-09T20:54:47Z

Command Bot: Processing...

github-actions · 2024-10-09T21:50:58Z

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

khalatepradnya · 2024-10-09T23:51:37Z

Command Bot: Processing...

Support for asynchronous sampling for ORCA backend --------- Co-authored-by: Pradnya Khalate <[email protected]> Signed-off-by: Omar Bacarreza <[email protected]>

Signed-off-by: Omar Bacarreza <[email protected]>

* Start on pure quantum struct usage in kernels Signed-off-by: Alex McCaskey <[email protected]> * Update the python bindings with new qstruct restrictions Signed-off-by: Alex McCaskey <[email protected]> * Enable default parenthesis constructor Signed-off-by: Alex McCaskey <[email protected]> * disallow recursive quantum struct Signed-off-by: Alex McCaskey <[email protected]> * Implement error handling for various cases in python Signed-off-by: Alex McCaskey <[email protected]> * spell fixes Signed-off-by: Alex McCaskey <[email protected]> * forgot to filter out __qpu__ methods on structs, those are allowed Signed-off-by: Alex McCaskey <[email protected]> * Add new quantum reference type, !quake.struq, and a couple of new operations: quake.make_struq and quake.get_member. These add the utility of having a product quantum reference type (to logically group together sets of qubits) but keep the classical and quantum dialects distinct. Update the tests, python ast bridge, C++ bridge, add codegen patterns, etc. * Whackamole games with the CI. Add roundtrip test on new type and ops. Update the python tests. Also change test to eliminate deprecation warnings. Add invlid IR checks for new operations. Add sanity checks. We do not want to allow a quantum struct that holds anything but non-owning references to qubits or qubit collections. Remove unused folder pattern. Workaround for overly assertive compiler warning. Reenable the hash-and-cache of extract_ref ops in the C++ bridge. This is a dubious optimization that we may actually want to take out at some point, but that should be part of a distinct/different PR. Update test to work around that pytest output can be shuffled. Add case to python for quake.struq type. Another python fix. Add explicit checks to utils.py. Stab in the dark. --------- Signed-off-by: Alex McCaskey <[email protected]> Co-authored-by: Alex McCaskey <[email protected]> Signed-off-by: Omar Bacarreza <[email protected]>

simulator YAML file. Signed-off-by: Omar Bacarreza <[email protected]>

Signed-off-by: Omar Bacarreza <[email protected]>

fix typo in 'return' Signed-off-by: Omar Bacarreza <[email protected]>

Signed-off-by: Omar Bacarreza <[email protected]>

* Random walk phase estimation example in Python NVIDIA#1579 * Formatting and spelling * Missed one formatting change --------- Co-authored-by: Bettina Heim <[email protected]> Signed-off-by: Omar Bacarreza <[email protected]>

* Fixes a bug with separate compilation. The bridge wasn't adding all possible `__qpu__` functions to the list, so the call converter wasn't converting a pure device kernel call on the device side. This change fixes that bug, updates the call converter to be able to add any missing declaration(s), and adds a regression test. Signed-off-by: Eric Schweitz <[email protected]> * Update the documentation. Signed-off-by: Eric Schweitz <[email protected]> --------- Signed-off-by: Eric Schweitz <[email protected]> Signed-off-by: Omar Bacarreza <[email protected]>

Removed custom operations Cleaned code Improve comments and function docs

Signed-off-by: Omar Bacarreza <[email protected]>

boschmitt · 2024-10-11T12:34:48Z

I cannot make much sense of what is going on in this PR. (It seems that the latest changes broke the diff.) That being said, the title "Fix Photonics get_state" doesn't seems to describe what this is doing: from what I can tell this is adding a whole parallel infrastructure for handling qudit-based computation.

The previous photonics work was supposed to be a stopgap until qudits became better supported in the stack. This PR seems to be working on the opposite direction: instead of improving the current infrastructure, it is creating a parallel one to handle qudits.

It seems to me that we don't even need to make CircuitSimulator operate on QuditInfo, we do need to give it the ability to know about qudits, but most of the methods in this new PhotonicCircuitSimulator work on qudit indices, which are exactly the same thing as qubit indices.

The point made about the gates being different is correct, but arguably the simulator should not provide gate methods, e.g. ccx(..) or beam_spliter(...), instead it should have a generic method that takes a matrix and the indices for either qubits or qudits.

Measurements are a bit more annoying but we could make so that CircuitSimulator layer returns a int8_t (or uint8_t), and then we properly cast it to bool when dealing with qubits, e.g., cudaq::mz will have a overload for cudaq::qubit that do the casting before returning to the user.

…users.noreply.github.com> I, Pradnya Khalate <[email protected]>, hereby add my Signed-off-by to this commit: 7c661ce I, Pradnya Khalate <[email protected]>, hereby add my Signed-off-by to this commit: d005f25 Signed-off-by: Pradnya Khalate <[email protected]>

….github.com> I, Pradnya Khalate <[email protected]>, hereby add my Signed-off-by to this commit: cc1acc1 Signed-off-by: Pradnya Khalate <[email protected]> DCO Remediation Commit for Pradnya Khalate <[email protected]> I, Pradnya Khalate <[email protected]>, hereby add my Signed-off-by to this commit: 7c661ce I, Pradnya Khalate <[email protected]>, hereby add my Signed-off-by to this commit: d005f25 I, Pradnya Khalate <[email protected]>, hereby add my Signed-off-by to this commit: 6fc6258 Signed-off-by: Pradnya Khalate <[email protected]>

khalatepradnya · 2024-10-11T21:54:14Z

docs/sphinx/api/default_ops.rst


-:code:`plus`
+:code:`create`


Q: Is this a new gate? or an alias for 'plus'? Doesn't match the examples and API spec...

This is a new gate replacing the plus that can be deprecated, the behaviour of the plus gate is not very intuitive (cycling through the number of photons).

khalatepradnya · 2024-10-11T21:54:48Z

docs/sphinx/api/default_ops.rst

-        plus(q[0]);
+        create(q[0]);
+
+:code:`annihilate`


Omar-ORCA · 2024-10-15T15:45:10Z

Superseded by #2283

schweitzpgi reviewed Oct 3, 2024

View reviewed changes

docs/sphinx/examples/cpp/providers/photonics_tbi_get_state.cpp Outdated Show resolved Hide resolved

schweitzpgi reviewed Oct 3, 2024

View reviewed changes

docs/sphinx/examples/cpp/providers/photonics_tbi_get_state.cpp Outdated Show resolved Hide resolved

schweitzpgi reviewed Oct 3, 2024

View reviewed changes

docs/sphinx/examples/cpp/providers/photonics_tbi_get_state.cpp Outdated Show resolved Hide resolved

schweitzpgi reviewed Oct 3, 2024

View reviewed changes

docs/sphinx/examples/cpp/providers/photonics_tbi_get_state.cpp Outdated Show resolved Hide resolved

schweitzpgi reviewed Oct 3, 2024

View reviewed changes

docs/sphinx/examples/cpp/providers/photonics_tbi_sample.cpp Show resolved Hide resolved

khalatepradnya reviewed Oct 3, 2024

View reviewed changes

runtime/cudaq/qis/managers/photonics/PhotonicsExecutionManager.cpp Outdated Show resolved Hide resolved

khalatepradnya reviewed Oct 3, 2024

View reviewed changes

runtime/cudaq/qis/managers/photonics/photonics_qis.h Show resolved Hide resolved

khalatepradnya reviewed Oct 4, 2024

View reviewed changes

runtime/nvqir/photonics/PhotonicCircuitSimulator.h Show resolved Hide resolved

khalatepradnya reviewed Oct 8, 2024

View reviewed changes

runtime/cudaq/cudaq.cpp Outdated Show resolved Hide resolved

github-actions bot pushed a commit that referenced this pull request Oct 8, 2024

Docs preview for PR #2243.

f830786

github-actions bot pushed a commit that referenced this pull request Oct 9, 2024

Docs preview for PR #2243.

5f00eee

khalatepradnya requested a review from amccaskey October 9, 2024 16:00

amccaskey reviewed Oct 9, 2024

View reviewed changes

docs/sphinx/examples/cpp/providers/photonics_tbi_get_state.cpp Outdated Show resolved Hide resolved

amccaskey reviewed Oct 9, 2024

View reviewed changes

runtime/nvqir/photonics/PhotonicGates.h Outdated Show resolved Hide resolved

github-actions bot pushed a commit that referenced this pull request Oct 9, 2024

Docs preview for PR #2243.

023d619

Omar-ORCA and others added 20 commits October 11, 2024 09:46

ORCA asynchronous sampling (NVIDIA#2205)

5a91961

Support for asynchronous sampling for ORCA backend --------- Co-authored-by: Pradnya Khalate <[email protected]> Signed-off-by: Omar Bacarreza <[email protected]>

Fix clang build

b5ad42a

Signed-off-by: Omar Bacarreza <[email protected]>

Allow controlled Z gates for profile-specific QIR (NVIDIA#2245)

d4a83f8

Signed-off-by: Omar Bacarreza <[email protected]>

* Restore the configuration for execution manager in the photnic

b80fb40

simulator YAML file. Signed-off-by: Omar Bacarreza <[email protected]>

* Restore unedited file.

095d2dd

Signed-off-by: Omar Bacarreza <[email protected]>

* Doxygen fix

4e78361

Signed-off-by: Omar Bacarreza <[email protected]>

Remove set_photonic_random_seed

a3f5c7d

Signed-off-by: Omar Bacarreza <[email protected]>

Return 0 from main in examples

32b3c6f

Signed-off-by: Omar Bacarreza <[email protected]>

Add multi-QPU support for the 'orca' target (NVIDIA#2260)

d6947ea

Signed-off-by: Omar Bacarreza <[email protected]>

* Code formatting

fe423bf

Signed-off-by: Omar Bacarreza <[email protected]>

* Addressing review comment - use cudaq::linspace API in C++ examples

2770546

Signed-off-by: Omar Bacarreza <[email protected]>

* Addressing review comment - use cudaq::linspace API in C++ examples;

2595c17

fix typo in 'return' Signed-off-by: Omar Bacarreza <[email protected]>

* Addressing review comment - remove superfluous 'else' after 'return'

2fba5ca

Signed-off-by: Omar Bacarreza <[email protected]>

Added new gates

6eda1f0

Removed custom operations Cleaned code Improve comments and function docs

Use the same parameters in the examples

b836772

Document photonics operations

fdcf7e9

Signed-off-by: Omar Bacarreza <[email protected]>

Fix photonics_tbi_get_state.py

492e995

Omar-ORCA force-pushed the photonics branch from 6ba6613 to 492e995 Compare October 11, 2024 09:14

Omar-ORCA requested review from bettinaheim and bmhowe23 as code owners October 11, 2024 09:14

khalatepradnya added 2 commits October 11, 2024 13:10

khalatepradnya reviewed Oct 11, 2024

View reviewed changes

docs/sphinx/api/default_ops.rst

plus(q[0]);

create(q[0]);

:code:`annihilate`

Copy link

Collaborator

khalatepradnya Oct 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto.

Omar-ORCA closed this Oct 15, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix Photonics `get_state` #2243

Fix Photonics `get_state` #2243

Omar-ORCA commented Oct 2, 2024

copy-pr-bot bot commented Oct 2, 2024

khalatepradnya commented Oct 3, 2024 •

edited by github-actions bot

Loading

khalatepradnya commented Oct 4, 2024 •

edited by github-actions bot

Loading

khalatepradnya commented Oct 4, 2024 •

edited by github-actions bot

Loading

khalatepradnya commented Oct 7, 2024 •

edited by github-actions bot

Loading

khalatepradnya commented Oct 8, 2024 •

edited by github-actions bot

Loading

khalatepradnya commented Oct 8, 2024 •

edited by github-actions bot

Loading

khalatepradnya commented Oct 8, 2024 •

edited by github-actions bot

Loading

github-actions bot commented Oct 8, 2024

khalatepradnya commented Oct 9, 2024 •

edited by github-actions bot

Loading

github-actions bot commented Oct 9, 2024

amccaskey commented Oct 9, 2024

khalatepradnya commented Oct 9, 2024 •

edited by github-actions bot

Loading

github-actions bot commented Oct 9, 2024

khalatepradnya commented Oct 9, 2024 •

edited by github-actions bot

Loading

boschmitt commented Oct 11, 2024 •

edited by amccaskey

Loading

khalatepradnya Oct 11, 2024

Omar-ORCA Oct 14, 2024

khalatepradnya Oct 11, 2024

Omar-ORCA commented Oct 15, 2024


		:code:`plus`
		:code:`create`

Fix Photonics get_state #2243

Fix Photonics get_state #2243

Conversation

Omar-ORCA commented Oct 2, 2024

copy-pr-bot bot commented Oct 2, 2024

khalatepradnya commented Oct 3, 2024 • edited by github-actions bot Loading

khalatepradnya commented Oct 4, 2024 • edited by github-actions bot Loading

khalatepradnya commented Oct 4, 2024 • edited by github-actions bot Loading

khalatepradnya commented Oct 7, 2024 • edited by github-actions bot Loading

khalatepradnya commented Oct 8, 2024 • edited by github-actions bot Loading

khalatepradnya commented Oct 8, 2024 • edited by github-actions bot Loading

khalatepradnya commented Oct 8, 2024 • edited by github-actions bot Loading

github-actions bot commented Oct 8, 2024

khalatepradnya commented Oct 9, 2024 • edited by github-actions bot Loading

github-actions bot commented Oct 9, 2024

amccaskey commented Oct 9, 2024

khalatepradnya commented Oct 9, 2024 • edited by github-actions bot Loading

github-actions bot commented Oct 9, 2024

khalatepradnya commented Oct 9, 2024 • edited by github-actions bot Loading

boschmitt commented Oct 11, 2024 • edited by amccaskey Loading

khalatepradnya Oct 11, 2024

Choose a reason for hiding this comment

Omar-ORCA Oct 14, 2024

Choose a reason for hiding this comment

khalatepradnya Oct 11, 2024

Choose a reason for hiding this comment

Omar-ORCA commented Oct 15, 2024

Fix Photonics `get_state` #2243

Fix Photonics `get_state` #2243

khalatepradnya commented Oct 3, 2024 •

edited by github-actions bot

Loading

khalatepradnya commented Oct 4, 2024 •

edited by github-actions bot

Loading

khalatepradnya commented Oct 4, 2024 •

edited by github-actions bot

Loading

khalatepradnya commented Oct 7, 2024 •

edited by github-actions bot

Loading

khalatepradnya commented Oct 8, 2024 •

edited by github-actions bot

Loading

khalatepradnya commented Oct 8, 2024 •

edited by github-actions bot

Loading

khalatepradnya commented Oct 8, 2024 •

edited by github-actions bot

Loading

khalatepradnya commented Oct 9, 2024 •

edited by github-actions bot

Loading

khalatepradnya commented Oct 9, 2024 •

edited by github-actions bot

Loading

khalatepradnya commented Oct 9, 2024 •

edited by github-actions bot

Loading

boschmitt commented Oct 11, 2024 •

edited by amccaskey

Loading