Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensure quantum_lib is built after nvq++ components are built #2290

Merged
merged 1 commit into from
Oct 17, 2024
Merged

ensure quantum_lib is built after nvq++ components are built #2290

merged 1 commit into from
Oct 17, 2024

Conversation

amccaskey
Copy link
Collaborator

A bad rebase removed the add_dependency line for the quantum_lib test library. Add that back here.

@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Oct 17, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

bmhowe23
bmhowe23 approved these changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@bmhowe23 bmhowe23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@amccaskey
Copy link
Collaborator Author

amccaskey commented Oct 17, 2024 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@amccaskey amccaskey enabled auto-merge (squash) October 17, 2024 15:32
@amccaskey amccaskey merged commit 78282ef into NVIDIA:main Oct 17, 2024
132 checks passed
@bettinaheim bettinaheim added the maintenance Work items to update and improve the code base label Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmhowe23 bmhowe23 bmhowe23 approved these changes

@schweitzpgi schweitzpgi schweitzpgi approved these changes

Assignees
No one assigned
Labels
maintenance Work items to update and improve the code base
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amccaskey @schweitzpgi @bmhowe23 @bettinaheim