-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support measurements of subveqs for braket #2416
Conversation
Signed-off-by: Anna Gringauze <[email protected]>
…aket-pipeline Signed-off-by: Anna Gringauze <[email protected]>
Signed-off-by: Anna Gringauze <[email protected]>
…aket-pipeline Signed-off-by: Anna Gringauze <[email protected]>
Signed-off-by: Anna Gringauze <[email protected]>
Signed-off-by: Anna Gringauze <[email protected]>
Signed-off-by: Anna Gringauze <[email protected]>
Signed-off-by: Anna Gringauze <[email protected]>
Signed-off-by: Anna Gringauze <[email protected]>
Signed-off-by: Pradnya Khalate <[email protected]>
* Two more tests working Signed-off-by: Pradnya Khalate <[email protected]>
* Additional tests Co-authored-by: Eric Schweitz <[email protected]> Signed-off-by: Pradnya Khalate <[email protected]>
Signed-off-by: Pradnya Khalate <[email protected]>
* Test for asynchronous sampling API * Failing test for observe API * More tests to cover all native gates, custom operations * One more test - check kernel that takes arguments Signed-off-by: Pradnya Khalate <[email protected]>
not supported. * Simplify test setup since mock server isn't being used. Signed-off-by: Pradnya Khalate <[email protected]>
Signed-off-by: Pradnya Khalate <[email protected]>
Co-authored-by: Bettina Heim <[email protected]> Signed-off-by: Pradnya Khalate <[email protected]>
Signed-off-by: Anna Gringauze <[email protected]>
Signed-off-by: Anna Gringauze <[email protected]>
Signed-off-by: Anna Gringauze <[email protected]>
Signed-off-by: Pradnya Khalate <[email protected]>
* Two more tests working Signed-off-by: Pradnya Khalate <[email protected]>
* Additional tests Co-authored-by: Eric Schweitz <[email protected]> Signed-off-by: Pradnya Khalate <[email protected]>
Signed-off-by: Pradnya Khalate <[email protected]>
* Test for asynchronous sampling API * Failing test for observe API * More tests to cover all native gates, custom operations * One more test - check kernel that takes arguments Signed-off-by: Pradnya Khalate <[email protected]>
not supported. * Simplify test setup since mock server isn't being used. Signed-off-by: Pradnya Khalate <[email protected]>
Signed-off-by: Pradnya Khalate <[email protected]>
Co-authored-by: Bettina Heim <[email protected]> Signed-off-by: Pradnya Khalate <[email protected]>
Signed-off-by: Pradnya Khalate <[email protected]>
runtime/cudaq/platform/default/rest/helpers/braket/BraketExecutor.cpp
Outdated
Show resolved
Hide resolved
runtime/cudaq/platform/default/rest/helpers/braket/BraketExecutor.cpp
Outdated
Show resolved
Hide resolved
runtime/cudaq/platform/default/rest/helpers/braket/BraketServerHelper.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Anna Gringauze <[email protected]>
Signed-off-by: Anna Gringauze <[email protected]>
…aket-pipeline-3 Signed-off-by: Anna Gringauze <[email protected]>
Signed-off-by: Anna Gringauze <[email protected]>
runtime/cudaq/platform/default/rest/helpers/braket/BraketServerHelper.cpp
Outdated
Show resolved
Hide resolved
runtime/cudaq/platform/default/rest/helpers/braket/BraketServerHelper.cpp
Show resolved
Hide resolved
Signed-off-by: Anna Gringauze <[email protected]>
Signed-off-by: Anna Gringauze <[email protected]>
I, Anna Gringauze <[email protected]>, hereby add my Signed-off-by to this commit: 3966ee3 Signed-off-by: Anna Gringauze <[email protected]>
…aket-pipeline-3 Signed-off-by: Anna Gringauze <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming the CI passes, these changes LGTM (modulo any new issues we need to open to track future work). Thanks for your quick work on this, @annagrin!
Pass<"combine-measurements", "mlir::func::FuncOp"> { | ||
let summary = "Extends mesurements on subveqs adds output names"; | ||
let description = [{ | ||
Replace a pattern such as: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to add documentation here that this transformation changes the semantics of the program. Running this pass produces a program that is not what the user wrote, so it is imperative that some sort of cleanup will be done to functionally cancel this transformation.
Description
Support measurements of subveqs for braket
CombineMeasurements
passsubveq
to the full vector and addoutput_names
attributestranslateToOpenQasm
pipeline that would be normally specified in target config files.