Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] enable the new QIR codegen for python #2588

Merged
merged 6 commits into from
Feb 7, 2025

Conversation

schweitzpgi
Copy link
Collaborator

@schweitzpgi schweitzpgi commented Feb 5, 2025

Remove the python hooks to the old codegen. This exposes all the python problems in the tests.

Eliminate the expansion of python enumerate().

Remove use of empty labels for all measurements.

This eliminates a loop, a data structure, and the invalid mixing of quantum and classical data values in classical memory.

Fix bugs in AST bridge.

Fix #2538 - measurement register name cannot be empty

Same code as in PR #2587

Copy link

github-actions bot commented Feb 5, 2025

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Feb 5, 2025
@schweitzpgi schweitzpgi enabled auto-merge (squash) February 5, 2025 23:30
@schweitzpgi schweitzpgi disabled auto-merge February 5, 2025 23:32
github-actions bot pushed a commit that referenced this pull request Feb 6, 2025
Copy link

github-actions bot commented Feb 6, 2025

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

Copy link

github-actions bot commented Feb 6, 2025

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Feb 6, 2025
python problems in the tests.

Eliminate the expansion of python enumerate().

Remove use of empty labels for all measurements.

This eliminates a loop, a data structure, and the invalid mixing of
quantum and classical data values in classical memory.

Fix bugs in AST bridge.

Fix NVIDIA#2538 - measurement register name cannot be empty.

Signed-off-by: Eric Schweitz <[email protected]>
github-actions bot pushed a commit that referenced this pull request Feb 6, 2025
Copy link

github-actions bot commented Feb 6, 2025

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

Signed-off-by: Eric Schweitz <[email protected]>
github-actions bot pushed a commit that referenced this pull request Feb 6, 2025
Copy link

github-actions bot commented Feb 6, 2025

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

@schweitzpgi schweitzpgi enabled auto-merge (squash) February 6, 2025 20:04
Copy link

github-actions bot commented Feb 6, 2025

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Feb 6, 2025
Copy link

github-actions bot commented Feb 7, 2025

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Feb 7, 2025
@schweitzpgi schweitzpgi requested a review from sacpis February 7, 2025 18:50
Copy link
Collaborator

@sacpis sacpis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just 2 questions. Thanks @schweitzpgi.

@schweitzpgi schweitzpgi merged commit 3602887 into NVIDIA:main Feb 7, 2025
213 checks passed
@schweitzpgi schweitzpgi deleted the ch-python.new.qirapi branch February 7, 2025 21:33
github-actions bot pushed a commit that referenced this pull request Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python kernel builder uses empty strings for measurement names
2 participants