-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] enable the new QIR codegen for python #2588
Conversation
15c40ab
to
f72512f
Compare
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
07d76b8
to
6f59a78
Compare
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
python problems in the tests. Eliminate the expansion of python enumerate(). Remove use of empty labels for all measurements. This eliminates a loop, a data structure, and the invalid mixing of quantum and classical data values in classical memory. Fix bugs in AST bridge. Fix NVIDIA#2538 - measurement register name cannot be empty. Signed-off-by: Eric Schweitz <[email protected]>
Signed-off-by: Eric Schweitz <[email protected]>
Signed-off-by: Eric Schweitz <[email protected]>
6f59a78
to
725b270
Compare
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
Signed-off-by: Eric Schweitz <[email protected]>
725b270
to
c85f28b
Compare
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
Signed-off-by: Eric Schweitz <[email protected]>
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just 2 questions. Thanks @schweitzpgi.
Remove the python hooks to the old codegen. This exposes all the python problems in the tests.
Eliminate the expansion of python enumerate().
Remove use of empty labels for all measurements.
This eliminates a loop, a data structure, and the invalid mixing of quantum and classical data values in classical memory.
Fix bugs in AST bridge.
Fix #2538 - measurement register name cannot be empty
Same code as in PR #2587