TLS and Basic Auth support #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mahendra Paipuri <[email protected]>
Signed-off-by: Mahendra Paipuri <[email protected]>
Signed-off-by: Mahendra Paipuri<[email protected]>
Signed-off-by: Mahendra Paipuri <[email protected]>
|
Hello, any chance that maintainers are interested in this feature? |
|
Yes, thank you for the contribution. We plan on reviewing this in the near future and before the next major release. |
Signed-off-by: mahendrapaipuri <[email protected]>
|
@glowkey Cheers for response. That is awesome. TLS and auth would be very handy for our HPC platform. |
nvvfedorov
requested changes
Dec 6, 2023
* dcgm-exporter supports only linux and if GOOS is not linux exit with message Signed-off-by: mahendrapaipuri <[email protected]>
glowkey
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the TLS and basic auth support to the exporter based on exporter toolkit. TLS and basic auth are opt-in and disabled by default. Users can enable them by passing a YAML file that has both TLS and basic auth config using
--web-config-fileflag.This PR completes #122 which has been stale for a while.
Cheers!