Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration tests for the TLS and basic authentication #219

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Integration tests for the TLS and basic authentication #219

merged 1 commit into from
Dec 18, 2023

Conversation

nvvfedorov
Copy link
Collaborator

The PR makes the following changes:

  1. The cmd package has been refactored to make it testable.
  2. Integration tests now test that the dcgm-exporter starts and produces metrics. Also, tests for TLS and basic authentication were added. Integration tests require hardware with a GPU installed for proper execution.
  3. Updated Makefile with new commands to run integration tests and linter and check that all dependencies are pushed to Github.
  4. Local copies of dependencies are now stored in the vendor folder.

@nvvfedorov nvvfedorov self-assigned this Dec 14, 2023
glowkey
glowkey reviewed Dec 14, 2023
View reviewed changes
Copy link
Collaborator

@glowkey glowkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nvvfedorov nvvfedorov requested a review from glowkey December 14, 2023 20:26
@nvvfedorov nvvfedorov force-pushed the tls_plus_integration_tests branch from e307225 to 0358f89 Compare December 14, 2023 21:38
glowkey
glowkey previously approved these changes Dec 14, 2023
View reviewed changes
@nvvfedorov nvvfedorov requested a review from glowkey December 15, 2023 19:38
@nvvfedorov nvvfedorov force-pushed the tls_plus_integration_tests branch from ac9c17c to e1ef247 Compare December 15, 2023 20:28
@nvvfedorov
Integration tests were added
c3919a5 
Signed-off-by: Vadym Fedorov <[email protected]>
@nvvfedorov nvvfedorov force-pushed the tls_plus_integration_tests branch from e1ef247 to c3919a5 Compare December 15, 2023 21:23
nikkon-dev
nikkon-dev approved these changes Dec 16, 2023
View reviewed changes
Copy link
Collaborator

@nikkon-dev nikkon-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nvvfedorov nvvfedorov merged commit 00e1d73 into main Dec 18, 2023
1 check passed
@nvvfedorov nvvfedorov deleted the tls_plus_integration_tests branch December 18, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikkon-dev nikkon-dev nikkon-dev approved these changes

@dbeer dbeer Awaiting requested review from dbeer

@glowkey glowkey Awaiting requested review from glowkey

Assignees

@nvvfedorov nvvfedorov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nvvfedorov @nikkon-dev @glowkey