Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go version updated to 1.21 #220

Merged
merged 5 commits into from
Dec 20, 2023
Merged

go version updated to 1.21 #220

merged 5 commits into from
Dec 20, 2023

Conversation

nvvfedorov
Copy link
Collaborator

Dockerfiles were updated to use GO1.21.

How to test:

  1. Build images
make local
  1. Run ubuntu20.04
docker run --gpus all --rm -p 9400:9400 docker.io/nvidia/dcgm-exporter:3.3.0-3.2.0-ubuntu20.04
  1. After ~30 seconds, make an HTTP request:
curl -v localhost:9400/metrics

You expected to see a list of metrics.

  1. Run Dockerfile.ubi8
docker run --gpus all --rm -p 9400:9400 docker.io/nvidia/dcgm-exporter:3.3.0-3.2.0-ubi8
  1. After ~30 seconds, make an HTTP request:
curl -v localhost:9400/metrics

You expected to see a list of metrics.

docker/Dockerfile.ubi8 Outdated Show resolved Hide resolved
nikkon-dev
nikkon-dev previously approved these changes Dec 18, 2023
Copy link
Collaborator

@nikkon-dev nikkon-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

glowkey
glowkey previously approved these changes Dec 18, 2023
nikkon-dev
nikkon-dev previously approved these changes Dec 18, 2023
@nvvfedorov nvvfedorov dismissed stale reviews from nikkon-dev and glowkey via ce1d5e5 December 18, 2023 20:18
@nvvfedorov nvvfedorov force-pushed the golang-version-upgrade branch from 8873b78 to ce1d5e5 Compare December 18, 2023 20:18
nikkon-dev
nikkon-dev previously approved these changes Dec 18, 2023
@nvvfedorov
Copy link
Collaborator Author

Vulnerability report received:
0 Critical
0 High
4 Medium
27 Low
3 Negligible
0 Unknown

@nvvfedorov nvvfedorov merged commit 32e8016 into main Dec 20, 2023
1 check passed
@nvvfedorov nvvfedorov deleted the golang-version-upgrade branch December 20, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants