Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile changes to update version information #286

Merged
merged 2 commits into from
Mar 18, 2024
Merged

Conversation

rohit-arora-dev
Copy link
Collaborator

Adding a change to make it easier to update version information in go, YAML, Makefile, and README files.
Automatically run this when creating a binary or when creating images.

The version information is stored in hack/VERSION, and should be updated to reflect the new version information at the time of the release.

Copy link
Collaborator

@nvvfedorov nvvfedorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address code review comments.

Makefile Outdated Show resolved Hide resolved
cmd/dcgm-exporter/main.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@nvvfedorov nvvfedorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rohit-arora-dev rohit-arora-dev merged commit 18009e6 into main Mar 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants