Skip to content

Commit

Permalink
ArmPkg/SmbiosMiscDxe: use UINT64 for BiosPhysicalSize
Browse files Browse the repository at this point in the history
The top two bits of the Extended BIOS ROM Size field indicates the unit
used for the remaining 14 bits. If the size is greater than 16GB, the
unit is gigabytes.
The test for this uses the local BiosPhysicalSize variable, which is a
UINTN, meaning that when building for ARM/CLANGDWARF we have a
tautological constant comparison, which the toolchain flags now we've
stopped disabling that warning.
So switch the BiosPhysicalSize variable to UINT64.

Signed-off-by: Leif Lindholm <[email protected]>
Cc: Ard Biesheuvel <[email protected]>
Cc: Rebecca Cran <[email protected]>
Reviewed-by: Ard Biesheuvel <[email protected]>
  • Loading branch information
leiflindholm authored and mergify[bot] committed Aug 30, 2023
1 parent 0c4d0b6 commit c5753c3
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ SMBIOS_MISC_TABLE_FUNCTION (MiscBiosVendor) {
UINTN VendorStrLen;
UINTN VerStrLen;
UINTN DateStrLen;
UINTN BiosPhysicalSize;
UINT64 BiosPhysicalSize;
CHAR16 *Vendor;
CHAR16 *Version;
CHAR16 *ReleaseDate;
Expand Down

0 comments on commit c5753c3

Please sign in to comment.