Skip to content

Commit

Permalink
DynamicTablesPkg: Add Aml NameUnicodeString API
Browse files Browse the repository at this point in the history
Add API to generate a Name that contains a Unicode string buffer.

Bug 4063340

Signed-off-by: Jeff Brasen <[email protected]>
Change-Id: I0116b2921cbbbecc3420ff7a42a7ab6e01852534
Reviewed-on: https://git-master.nvidia.com/r/c/3rdparty/edk2/+/2887339
Reviewed-by: svcacv <[email protected]>
Reviewed-by: svc-sw-mobile-l4t <[email protected]>
Reviewed-by: Swatisri Kantamsetti <[email protected]>
Reviewed-by: Ashish Singhal <[email protected]>
GVS: Gerrit_Virtual_Submit <[email protected]>
  • Loading branch information
jbrasen committed Jun 29, 2023
1 parent 407dc3c commit ef38fa9
Show file tree
Hide file tree
Showing 2 changed files with 117 additions and 0 deletions.
31 changes: 31 additions & 0 deletions DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h
Original file line number Diff line number Diff line change
Expand Up @@ -958,6 +958,37 @@ AmlCodeGenNameResourceTemplate (
OUT AML_OBJECT_NODE_HANDLE *NewObjectNode OPTIONAL
);

/** AML code generation for a Name object node, containing a String.
AmlCodeGenNameUnicodeString ("_STR", L"String", ParentNode, NewObjectNode) is
equivalent of the following ASL code:
Name(_STR, Unicode ("String"))
@ingroup CodeGenApis
@param [in] NameString The new variable name.
Must be a NULL-terminated ASL NameString
e.g.: "DEV0", "DV15.DEV0", etc.
The input string is copied.
@param [in] String NULL terminated Unicode String to associate to the
NameString.
@param [in] ParentNode If provided, set ParentNode as the parent
of the node created.
@param [out] NewObjectNode If success, contains the created node.
@retval EFI_SUCCESS Success.
@retval EFI_INVALID_PARAMETER Invalid parameter.
@retval EFI_OUT_OF_RESOURCES Failed to allocate memory.
**/
EFI_STATUS
EFIAPI
AmlCodeGenNameUnicodeString (
IN CONST CHAR8 *NameString,
IN CHAR16 *String,
IN AML_NODE_HANDLE ParentNode OPTIONAL,
OUT AML_OBJECT_NODE_HANDLE *NewObjectNode OPTIONAL
);

/** Add a _PRT entry.
AmlCodeGenPrtEntry (0x0FFFF, 0, "LNKA", 0, PrtNameNode) is
Expand Down
86 changes: 86 additions & 0 deletions DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c
Original file line number Diff line number Diff line change
Expand Up @@ -869,6 +869,92 @@ AmlCodeGenNameResourceTemplate (
return Status;
}

/** AML code generation for a Name object node, containing a String.
AmlCodeGenNameUnicodeString ("_STR", L"String", ParentNode, NewObjectNode) is
equivalent of the following ASL code:
Name(_STR, Unicode ("String"))
@ingroup CodeGenApis
@param [in] NameString The new variable name.
Must be a NULL-terminated ASL NameString
e.g.: "DEV0", "DV15.DEV0", etc.
The input string is copied.
@param [in] String NULL terminated Unicode String to associate to the
NameString.
@param [in] ParentNode If provided, set ParentNode as the parent
of the node created.
@param [out] NewObjectNode If success, contains the created node.
@retval EFI_SUCCESS Success.
@retval EFI_INVALID_PARAMETER Invalid parameter.
@retval EFI_OUT_OF_RESOURCES Failed to allocate memory.
**/
EFI_STATUS
EFIAPI
AmlCodeGenNameUnicodeString (
IN CONST CHAR8 *NameString,
IN CHAR16 *String,
IN AML_NODE_HANDLE ParentNode OPTIONAL,
OUT AML_OBJECT_NODE_HANDLE *NewObjectNode OPTIONAL
)
{
EFI_STATUS Status;
AML_OBJECT_NODE *ObjectNode;
AML_DATA_NODE *DataNode;

if ((NameString == NULL) ||
(String == NULL) ||
((ParentNode == NULL) && (NewObjectNode == NULL)))
{
ASSERT (0);
return EFI_INVALID_PARAMETER;
}

Status = AmlCodeGenBuffer (NULL, 0, &ObjectNode);
if (EFI_ERROR (Status)) {
ASSERT_EFI_ERROR (Status);
return Status;
}

Status = AmlCreateDataNode (
EAmlNodeDataTypeRaw,
(CONST UINT8 *)String,
StrSize (String),
&DataNode
);
if (EFI_ERROR (Status)) {
ASSERT_EFI_ERROR (Status);
AmlDeleteTree ((AML_NODE_HEADER *)ObjectNode);
return Status;
}

Status = AmlVarListAddTail (
(AML_NODE_HEADER *)ObjectNode,
(AML_NODE_HEADER *)DataNode
);
if (EFI_ERROR (Status)) {
ASSERT_EFI_ERROR (Status);
AmlDeleteTree ((AML_NODE_HEADER *)ObjectNode);
AmlDeleteTree ((AML_NODE_HANDLE)DataNode);
return Status;
}

Status = AmlCodeGenName (
NameString,
ObjectNode,
ParentNode,
NewObjectNode
);
if (EFI_ERROR (Status)) {
ASSERT (0);
AmlDeleteTree ((AML_NODE_HEADER *)ObjectNode);
}

return Status;
}

/** Add a _PRT entry.
AmlCodeGenPrtEntry (0x0FFFF, 0, "LNKA", 0, PrtNameNode) is
Expand Down

0 comments on commit ef38fa9

Please sign in to comment.