add CODEOWNERS #1001
add CODEOWNERS #1001
Conversation
enforce CODEOWNERS on .github files to restirct workflow and template changes as requiring approval by maintainers Signed-off-by: Jeffrey Martin <[email protected]>
|
See docs |
| @@ -0,0 +1 @@ | |||
| /.github/ @leondz @erickgalinkin @jmartin-tech | |||
There was a problem hiding this comment.
Do we also want to add ourselves as global owners for review tagging? Or are we only aiming for branch protection for the CODEOWNERS file?
There was a problem hiding this comment.
I would say no, I do not currently want all PRs to auto-request review.
This is intended for protection of automation artifacts by requiring a maintainer to approve landing any PR that may change those workflows. I can see a future where there are experts on certain segments of the codebase that would be desirable to tag on reviews of changes in those areas, the project is not that complex at this time.
There was a problem hiding this comment.
I think having a .github restriction, separate from global config/restrictions, is a good extra layer of protection
| @@ -0,0 +1 @@ | |||
| /.github/ @leondz @erickgalinkin @jmartin-tech | |||
There was a problem hiding this comment.
I think having a .github restriction, separate from global config/restrictions, is a good extra layer of protection
Enforce approval requirements for changes that may impact automation.