Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StringDetector.case_sensitive now operates as expected #1072

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

leondz
Copy link
Collaborator

@leondz leondz commented Jan 13, 2025

resolves #1054

  • fix StringDetector case sensitivity - was inverted
  • add dedicated tests for detector bases
  • add tests for matchtype

Thanks to @Eric-Hacker for the tests in the report!

@leondz leondz added bug Something isn't working detectors work on code that inherits from or manages Detector labels Jan 13, 2025
@Eric-Hacker
Copy link
Contributor

Thank you for the recognition.

Copy link
Collaborator

@jmartin-tech jmartin-tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the additional testing code.

@jmartin-tech jmartin-tech merged commit 037c3d0 into NVIDIA:main Jan 13, 2025
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working detectors work on code that inherits from or manages Detector
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StringDetector case sensitivity seems inverted.
3 participants