Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

init zscore with enough scope to cover its uses #1086

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

leondz
Copy link
Collaborator

@leondz leondz commented Jan 20, 2025

may resolve #1082

initialise zscore in evaluators.base at a high enough scope that it has a value before it's checked.

Copy link
Collaborator

@jmartin-tech jmartin-tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Static review looks good.

@jmartin-tech jmartin-tech merged commit 81aca1e into NVIDIA:main Jan 21, 2025
9 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash due to zscore not initialised error when using the Azure generator as DAN probes are skipped
2 participants