-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix darwin do not support --export-dynamic
#50
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Zhang Wei <[email protected]>
Hi @nvvfedorov, can you please also look at this one |
Thank you for your contribution. The dcgm (https://docs.nvidia.com/datacenter/dcgm/latest/user-guide/getting-started.html#supported-platforms) doesn't support platforms other than Linux. The fix may help compile dcgm-exporter for development purposes. However, the binary will not work on the Mac without the DCGM library, and the build doesn't guarantee that the compiled binary works as expected. I think it makes sense to add a VS CODE dev container to the repository and use it for development. Here is the example from the DCGM library: https://github.com/NVIDIA/DCGM/blob/master/.devcontainer/devcontainer.json |
Hi @nvvfedorov, I agree with you mostly, with my little two cents:
yes, and local development is important for developers.
it does not have to guarantee that, it works for development is all good enough, or there will be plant warnings in editors. and we will always build the test/release binary in a container.
developers other than VSCode, it does not always have the container development env setup, or is not that necessary to setup one just for rolling into the development. what's more, the |
It makes sense to me. @nikkon-dev , @glowkey, what do you think? |
I am going to test the PR, and I will be back this week. |
which will met error: