Merge pull request #1124 from NVIDIA/upd-golangci-lint

update golangci-lint version to v1.62.0 and pass in version via GITHUB_ENV
NVIDIA · Nov 20, 2024 · 4ec60f9 · 4ec60f9
2 parents 9378108 + 6187795
commit 4ec60f9
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -41,7 +41,9 @@ jobs:
         id: vars
         run: |
           GOLANG_VERSION=$( grep "GOLANG_VERSION ?=" versions.mk )
+          GOLANGCI_LINT_VERSION=$( grep "GOLANGCI_LINT_VERSION ?=" versions.mk )
           echo "GOLANG_VERSION=${GOLANG_VERSION##GOLANG_VERSION ?= }" >> $GITHUB_ENV
+          echo "GOLANGCI_LINT_VERSION=${GOLANGCI_LINT_VERSION##GOLANGCI_LINT_VERSION ?= }" >> $GITHUB_ENV
       - name: Install Go
         uses: actions/setup-go@v5
         with:
@@ -82,7 +84,7 @@ jobs:
       - name: Lint
         uses: golangci/golangci-lint-action@v6
         with:
-          version: v1.60.3
+          version: ${{ env.GOLANGCI_LINT_VERSION }}
           args: -v --timeout 5m
           skip-cache: true
       - run: make check

diff --git a/versions.mk b/versions.mk
@@ -21,4 +21,6 @@ VERSION ?= v24.9.0
 
 GOLANG_VERSION ?= 1.23.3
 
+GOLANGCI_LINT_VERSION ?= v1.62.0
+
 GIT_COMMIT ?= $(shell git describe --match="" --dirty --long --always 2> /dev/null || echo "")