Add e2e github action #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArangoGutierrez
added
the
testing
ArangoGutierrez
force-pushed
the
e2eactions
branch
6 times, most recently
from
76bbecd
to
9c27ff4
Compare
ArangoGutierrez
force-pushed
the
e2eactions
branch
2 times, most recently
from
c2d18e3
to
f0814d9
Compare
elezar
reviewed
Mar 5, 2024
elezar
reviewed
Mar 5, 2024
elezar
reviewed
Mar 5, 2024
ArangoGutierrez
force-pushed
the
e2eactions
branch
from
f0814d9
to
feb3875
Compare
ArangoGutierrez
force-pushed
the
e2eactions
branch
from
feb3875
to
e28f8b3
Compare
ArangoGutierrez
force-pushed
the
e2eactions
branch
from
e28f8b3
to
3911d1a
Compare
|
@elezar PTAL |
elezar
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
Thanks @ArangoGutierrez. I think the triggers etc look sane now. I have some minor comments, but we can handle those as follow-ups.
| run: | | ||
| echo "COMMIT_SHORT_SHA=${GITHUB_SHA:0:8}" >> $GITHUB_ENV | ||
| - name: Set up Holodeck | ||
| uses: NVIDIA/holodeck@main |
There was a problem hiding this comment.
out of scope: Do we want to tag this with a version at some point?
There was a problem hiding this comment.
I will cut a version once we are happy with it, I still feel is a bit unstable.
| install: true | ||
| kubernetes: | ||
| install: true | ||
| installer: kubeadm |
There was a problem hiding this comment.
If this is the default I think we can remove it. Note a blocker for this PR though.
There was a problem hiding this comment.
we can remove, yes. but I wanted to be very explicit at the first try
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
ArangoGutierrez
force-pushed
the
e2eactions
branch
from
3911d1a
to
f3586af
Compare
elezar
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.