Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve build system #262

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Improve build system #262

wants to merge 5 commits into from

Conversation

lahwaacz
Copy link

These changes make building with system flags and libs more straightforward or actually possible. I had to patch the build system a lot while making a package for Arch Linux.

…ng their own flags

For example, Arch Linux wants debug information in the binaries.

Signed-off-by: Jakub Klinkovský <[email protected]>
For example, Arch Linux strips debug information after build during the
package creation and producing separate debug info files during the
build interferes with the Arch tooling.

Signed-off-by: Jakub Klinkovský <[email protected]>
…SECCOMP

"yes" means linking to system libtirpc, "no" means building libtirpc from source.

Signed-off-by: Jakub Klinkovský <[email protected]>
@lahwaacz
Copy link
Author

@elezar Can you look at this please? 🙏

@elezar elezar self-assigned this May 22, 2024
@elezar
Copy link
Member

elezar commented May 22, 2024

@lahwaacz sorry for the delay. I will have a look.

@elezar elezar requested review from elezar and klueska and removed request for elezar May 23, 2024 08:33
Copy link
Member

@elezar elezar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes.

I think they look good. The one thing missing is ensuring that the defaults for all major platforms are the same given the WITH_TIRPC changes.

src/nvcgo/Makefile Show resolved Hide resolved
Makefile Show resolved Hide resolved
@lahwaacz
Copy link
Author

@elezar Any progress with merging this? It's been almost half a year...

@lahwaacz lahwaacz requested a review from elezar October 1, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants