Improve build system #262
Improve build system #262
Conversation
Signed-off-by: Jakub Klinkovský <[email protected]>
…file Signed-off-by: Jakub Klinkovský <[email protected]>
…ng their own flags For example, Arch Linux wants debug information in the binaries. Signed-off-by: Jakub Klinkovský <[email protected]>
For example, Arch Linux strips debug information after build during the package creation and producing separate debug info files during the build interferes with the Arch tooling. Signed-off-by: Jakub Klinkovský <[email protected]>
…SECCOMP "yes" means linking to system libtirpc, "no" means building libtirpc from source. Signed-off-by: Jakub Klinkovský <[email protected]>
|
@elezar Can you look at this please? 🙏 |
|
@lahwaacz sorry for the delay. I will have a look. |
| @@ -31,8 +31,8 @@ OBJ_NAME := $(LIB_NAME).so | |||
| HDR_NAME := $(LIB_NAME).h | |||
| CTYPES_H := ctypes.h | |||
|
|
|||
| CGO_CFLAGS := -std=gnu11 -O2 | |||
| CGO_LDFLAGS := -Wl,--gc-sections -Wl,-s -Wl,-soname,$(LIB_SONAME) | |||
| CGO_CFLAGS := -std=gnu11 -O2 $(CGO_CFLAGS) | |||
There was a problem hiding this comment.
Does using += over := make sense in this context?
There was a problem hiding this comment.
Using += instead of := would change the order of the flags. The user's CGO_CFLAGS should be at the end so they can override the project defaults (particularly the optimization level).
There was a problem hiding this comment.
Since we've flipped the meaning of WITH_TIRPC, do we not need to also update the default?
At the very least we chould also update the ARG WITH_TIRPC set in the various docker files.
There was a problem hiding this comment.
Well, the meaning of WITH_TIRPC was not flipped:
- before: "yes" means building libtirpc from source, "no" means don't use libtirpc at all (I think)
- after: "yes" means linking to system libtirpc, "no" means building libtirpc from source
I've checked the Dockerfiles and they seem correct: Dockerfile.centos installs libtirpc-devel and has WITH_TIRPC=yes, all others have WITH_TIRPC=no since they don't install the system package.
There was a problem hiding this comment.
Previously no meant -- use the native sunrpc library that is bundled in the OS (instead of tirpc).
There was a problem hiding this comment.
@elezar Can this be marked as resolved or do you think some changes are needed?
|
@elezar Any progress with merging this? It's been almost half a year... |
These changes make building with system flags and libs more straightforward or actually possible. I had to patch the build system a lot while making a package for Arch Linux.