Split Helm doc sections for <= 24.08 and > 24.08 #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edknv
reviewed
Oct 3, 2024
helm/README.md
Outdated
Comment on lines
153
to
157
| # Download the 24.08 .whl | ||
| wget https://github.com/NVIDIA/nv-ingest/releases/download/24.08/nv_ingest_client-24.08-py3-none-any.whl | ||
|
|
||
| # Pip install that .whl | ||
| pip install nv_ingest_client-24.08-py3-none-any.whl |
There was a problem hiding this comment.
Should the versions be 24.09 not 24.08 in these commands?
There was a problem hiding this comment.
Or, looking at the instructions just above For versions > 24.08 we recommend building nv-ingest-cli from source to ensure you have the latest code, should it be pip install /path/to/nv-ingest/client?
dnola
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make the documentation more clear around versions. Include specific instructions for using versions <= 24.08 and instructions for using > 24.08 since there are some notable differences between how the 2 are accessed and specifically around the
nv-ingest-cliChecklist