Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use NVIDIA endpoints in example notebooks and demonstrate using milvus as a vector database #141

Merged
merged 13 commits into from
Nov 22, 2024
Merged

Use NVIDIA endpoints in example notebooks and demonstrate using milvus as a vector database #141

merged 13 commits into from
Nov 22, 2024

Conversation

ChrisJar
Copy link
Collaborator

@ChrisJar ChrisJar commented Oct 3, 2024 •
edited
Loading

Description

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

TODO:

  • Demonstrate add example vdbupload and store tasks (still working out how to hook this into llamaindex and langchain)
  • Demonstrate storing with minio and fetching and displaying some of the images

closes #122
closes #124

randerzander
randerzander requested changes Oct 9, 2024
View reviewed changes
Copy link
Collaborator

@randerzander randerzander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left several review comments to be addressed

@ChrisJar ChrisJar changed the title Use nvidia enpoints in example notebooks and demonstrate using milvus as a store" Use NVIDIA endpoints in example notebooks and demonstrate using milvus as a store Oct 15, 2024
@ChrisJar ChrisJar changed the title Use NVIDIA endpoints in example notebooks and demonstrate using milvus as a store Use NVIDIA endpoints in example notebooks and demonstrate using milvus as a vector database Oct 15, 2024
@ChrisJar ChrisJar changed the title Use NVIDIA endpoints in example notebooks and demonstrate using milvus as a vector database [Do Not Merge] Use NVIDIA endpoints in example notebooks and demonstrate using milvus as a vector database Oct 15, 2024
@ChrisJar ChrisJar changed the title [Do Not Merge] Use NVIDIA endpoints in example notebooks and demonstrate using milvus as a vector database Use NVIDIA endpoints in example notebooks and demonstrate using milvus as a vector database Oct 31, 2024
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Nov 12, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@ChrisJar ChrisJar mentioned this pull request Nov 12, 2024
Open
3 tasks
@ChrisJar ChrisJar merged commit 68e7cc7 into NVIDIA:main Nov 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drobison00 drobison00 drobison00 approved these changes

@randerzander randerzander Awaiting requested review from randerzander

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@ChrisJar @randerzander @drobison00