Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract tables and charts by default in ingestor extract #227

Merged
merged 2 commits into from
Nov 14, 2024
Merged

Extract tables and charts by default in ingestor extract #227

merged 2 commits into from
Nov 14, 2024

Conversation

edknv
Copy link
Collaborator

@edknv edknv commented Nov 13, 2024 •
edited
Loading

Description

  • Sets extract_tables and extract_charts to true by default in Ingestor.extract().
  • Adds an extra check in pdfium helper so that if one of those parameters is set to False, the corresponding type is not extracted.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@edknv edknv merged commit 442e34e into NVIDIA:main Nov 14, 2024
1 check passed
@edknv edknv deleted the fix/extract-table-chart-default-true branch November 14, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drobison00 drobison00 drobison00 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edknv @drobison00