Close race condition window (#623)

* Add additional check when reacquiring lock.
NVIDIA · May 8, 2021 · 5bf47fd · 5bf47fd
1 parent baadd2f
commit 5bf47fd
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/retryrpc/client.go b/retryrpc/client.go
@@ -278,6 +278,14 @@ func (client *Client) notifyReply(buf []byte, genNum uint64, recvResponse time.T
 		client.Unlock()
 		return
 	}
+
+	_, ok = client.outstandingRequest[crID]
+	if !ok {
+		// Saw reply for request which is no longer on outstandingRequest list
+		// Can happen if handling retransmit
+		client.Unlock()
+		return
+	}
 	delete(client.outstandingRequest, crID)
 	client.Unlock()