Add tags to skip Triton cells for CI/CD #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rishi Chandra <[email protected]>
eordentlich
previously approved these changes
Oct 22, 2024
|
Test passed in my latest test, thanks! |
YanxuanLiu
approved these changes
Oct 25, 2024
parthosa
pushed a commit
to parthosa/spark-rapids-examples
that referenced
this pull request
Oct 30, 2024
* Add Triton cell tags Signed-off-by: Rishi Chandra <[email protected]> * Avoid relative paths in tf notebooks * Use pathlib for relative dirs * Account for tensorflow extraction path bug --------- Signed-off-by: Rishi Chandra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Triton:
After discussing with @YanxuanLiu @eordentlich, we are skipping the Triton portions of the DL notebooks for now, allowing us to run the notebooks in Docker on the pipeline (in conjunction with this PR).
Added "TRITON" cell tags to all Triton-related cells to enable using Jupyter TagPreprocessor to detect and skip Triton cells without modifying any code on the user-end.
Triton cells can be re-enabled when we have either safe Docker-in-Docker execution or we refactor to use PyTriton client (in progress).
Bugs:
Avoiding use of relative paths for datasets to address CI failures in text_classification_tf and feature_columns_tf.