Logistic Regression Support for DataGen #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
build |
lijinf2
reviewed
Feb 12, 2024
| # Logistric Regression sigmoid and sample | ||
| if logistic_regression: | ||
| if use_cupy: | ||
| prob = 1 - 1 / (1 + cp.exp(-y)) |
There was a problem hiding this comment.
It seems y gets larger, prob will be smaller. Maybe not an issue. PR looks good.
There was a problem hiding this comment.
Yes if this is prob of selecting 1, it should be 1/(1 + exp(-y))
eordentlich
reviewed
Feb 12, 2024
.github/workflows/blossom-ci.yml
Outdated
| NvTimLiu,\ | ||
| YanxuanLiu,\ | ||
| zhanga5,\ | ||
| rishic3,\ | ||
| Er1cCheng,\ |
There was a problem hiding this comment.
Strange. This change was already merged in. Not clear why it is showing as diff.
There was a problem hiding this comment.
I think maybe I did the merge in a wrong way so it's pulled as a diff.
|
build |
1 similar comment
|
build |
Er1cCheng
force-pushed
the
branch-24.02
branch
from
2f44219 to
1c43d95
Compare
|
build |
1 similar comment
|
build |
lijinf2
approved these changes
Feb 13, 2024
|
As a followup, will be good to add some help information for the new logistic option. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add in support for generate random logistic regression binary label used for benchmark. Minor bug fix for argument parsing.