[LogisticRegression] Padding zeros to bypass the out-of-bound memory access of the raft stats (sum, mean, stddev) kernels #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m cuda kernel Signed-off-by: Jinfeng <[email protected]>
|
build |
eordentlich
reviewed
Feb 20, 2024
| @@ -979,9 +979,33 @@ def _logistic_regression_fit( | |||
| if self.getStandardization() is True and is_sparse is True: | |||
| concated = concated.toarray() | |||
|
|
|||
| num_pad_zero_cols = 0 | |||
| if self.getStandardization() is True and concated.shape[1] % 32 != 0: | |||
| num_pad_zero_cols = concated.shape[1] % 32 | |||
There was a problem hiding this comment.
Shouldn't the number of padding columns be 32 - concated.shape[1] % 32 ?
|
build |
eordentlich
reviewed
Feb 20, 2024
| @@ -979,9 +979,35 @@ def _logistic_regression_fit( | |||
| if self.getStandardization() is True and is_sparse is True: | |||
| concated = concated.toarray() | |||
|
|
|||
| num_pad_zero_cols = 0 | |||
There was a problem hiding this comment.
Maybe add a comment about why this is done and that it is temporary work around.
There was a problem hiding this comment.
Sounds good. Added a comment.
|
build |
|
build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a workaround to bypass gpu memory out-of-bound access of raft 24.02.