Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the no-data-modification standardization of cuml #802

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

lijinf2
Copy link
Collaborator

@lijinf2 lijinf2 commented Dec 10, 2024

No description provided.

@lijinf2
Copy link
Collaborator Author

lijinf2 commented Dec 10, 2024

build

2 similar comments
@lijinf2
Copy link
Collaborator Author

lijinf2 commented Dec 10, 2024

build

@lijinf2
Copy link
Collaborator Author

lijinf2 commented Dec 10, 2024

build

@lijinf2
Copy link
Collaborator Author

lijinf2 commented Dec 10, 2024

build

@lijinf2
Copy link
Collaborator Author

lijinf2 commented Dec 11, 2024

build

…kernel are working good for calculating mean and stddev

revise cpu memory requirement for tests_large to 256g

revise test_compat to reproduce error, passed on single gpu fails on two gpus due to variance incorrect

Signed-off-by: Jinfeng <[email protected]>
refine test cases

relax tolerance from 1e-4 to 1e-3 for comparing intercept_ when standardization is true in test_compat

relax tolerance for the second place comparing intercept
@lijinf2
Copy link
Collaborator Author

lijinf2 commented Dec 11, 2024

build

Copy link
Collaborator

@eordentlich eordentlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lijinf2 lijinf2 merged commit 6cbc036 into NVIDIA:branch-24.12 Dec 12, 2024
3 checks passed
@lijinf2 lijinf2 deleted the raft_stat_1118 branch December 12, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants