Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require metadata on all topology #26

Merged
merged 6 commits into from
Nov 14, 2024
Merged

Require metadata on all topology #26

merged 6 commits into from
Nov 14, 2024

Conversation

henryh2
Copy link
Collaborator

@henryh2 henryh2 commented Nov 2, 2024

Requires metadata to be set on all topology, including both tree and block topology.

@henryh2
Copy link
Collaborator Author

henryh2 commented Nov 2, 2024

Two comments regarding this PR, the first of which is:

If the topology request payload specifies a topology plugin (either tree or block) that is different than the topology that can be provided, what should be the action? Return an error in the request?

@henryh2
Copy link
Collaborator Author

henryh2 commented Nov 2, 2024

And second, for MNNVL, is block topology always returned (current implementation), or should tree topology be returned in some situations?

pkg/models/model.go Outdated Show resolved Hide resolved
@dmitsh
Copy link
Collaborator

dmitsh commented Nov 2, 2024

If the topology request payload specifies a topology plugin (either tree or block) that is different than the topology that can be provided, what should be the action? Return an error in the request?

Toposim (and GTS) returns a collections of nodes with their local topology (a chain of switches and/or presence of nvlink).
From here we can construct either tree or block topology. So, IIUC, it is up to the requester to define. IMO we should consider tree topology as default.

pkg/ib/ib.go Show resolved Hide resolved
Signed-off-by: Henry Haase <[email protected]>
Signed-off-by: Henry Haase <[email protected]>
Signed-off-by: Henry Haase <[email protected]>
@henryh2 henryh2 merged commit 541db3e into main Nov 14, 2024
4 checks passed
@henryh2 henryh2 deleted the metadata-fix branch November 14, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants