Structural Refactor #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henryh2
previously approved these changes
Nov 7, 2024
- Decoupling providers and engines via interfaces and loader pattern - CSP SDKs are accessed via interfaces to support mocking - `GetComputeInstances` moved to and driven by engines instead of providers Signed-off-by: Phil Kedy <[email protected]>
pkedy
force-pushed
the
structural-refactor
branch
from
4be46fc
to
c0aac28
Compare
dmitsh
approved these changes
Nov 7, 2024
henryh2
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(e.g.
common,utils,const->engines,providers,topology)interfacedependencies to support mockingprovider::GetCredentialsremoved and credentials no longer passed toprovider::GenerateTopologyConfigInstead, clients are created and passed to providers via
Newas explicit dependenciesGetComputeInstancesmoved fromproviderstoengines(It seems like engines really drive this)configwrapper aroundmapstructureto convert params (map[string]string|any) to a struct for type safety, validation, and readability