Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added aws-sim provider #34

Merged
merged 7 commits into from
Nov 20, 2024
Merged

Added aws-sim provider #34

merged 7 commits into from
Nov 20, 2024

Conversation

henryh2
Copy link
Collaborator

@henryh2 henryh2 commented Nov 18, 2024

Added functionallity for an 'aws-sim' provider that can be used to simulate the AWS capacity blocks API.

@henryh2 henryh2 marked this pull request as ready for review November 19, 2024 13:00
@henryh2
Copy link
Collaborator Author

henryh2 commented Nov 19, 2024

Potential items that should be considered for this MR:

  • Exploring the edge cases for DescribeInstanceTopology endpoint, and how the API responds to incorrect input.
  • Test to make sure multiple "pages" work correctly within the simulated client
  • Add more test cases for the model structure
  • Do more in-depth validation of model structure on import

Signed-off-by: Dmitry Shmulevich <[email protected]>
pkedy
pkedy previously approved these changes Nov 19, 2024
Copy link
Collaborator

@pkedy pkedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple style nits.

pkg/providers/aws/provider_sim.go Outdated Show resolved Hide resolved
pkg/providers/aws/provider_sim.go Outdated Show resolved Hide resolved
@pkedy
Copy link
Collaborator

pkedy commented Nov 19, 2024

For a future PR: Since this is a simulated implementation, it should have a unit test.

Signed-off-by: Henry Haase <[email protected]>
@henryh2 henryh2 merged commit 716a491 into main Nov 20, 2024
4 checks passed
@henryh2 henryh2 deleted the aws-mock branch November 20, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants