improve cdbg exports #1364
Merged
improve cdbg exports #1364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damonmcc
force-pushed
the
dm-cdbg-exports
branch
from
8e4f5a1 to
26beda3
Compare
damonmcc
force-pushed
the
dm-cdbg-exports
branch
from
26beda3 to
f3f2fd0
Compare
fvankrieken
reviewed
Jan 3, 2025
| @@ -66,11 +66,11 @@ models: | |||
| data_type: string | |||
| tests: [not_null] | |||
|
|
|||
| - name: cdbg_borough | |||
| - name: cdbg_boroughs | |||
| description: Borough and city-wide Community Development Block Grant (CDBG) details | |||
| config: | |||
There was a problem hiding this comment.
Let's just drop the config field entirely?
There was a problem hiding this comment.
I was gonna try enforcing them next, but in another PR
edit: gonna do the contracts here
damonmcc
force-pushed
the
dm-cdbg-exports
branch
from
4680d8f to
4b55c76
Compare
damonmcc
force-pushed
the
dm-cdbg-exports
branch
from
4b55c76 to
574830f
Compare
pinning to HUD source data version was recommended by OMB
fvankrieken
reviewed
Jan 6, 2025
| borough_code, | ||
| tract, | ||
| block_group, | ||
| round(total_floor_area::numeric)::integer AS total_floor_area, |
There was a problem hiding this comment.
what's the data type before the cast to numeric?
There was a problem hiding this comment.
I guess double precision - I forgot you can't just round that.
I do think you can just cast a double precision to integer to round though
There was a problem hiding this comment.
gotcha. I wasn't sure if casting to integer would round correcting, always round in one direction, or truncate
fvankrieken
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #1348
all builds on this branch here
probably easier to review each commit to see changes