Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: chaining #19

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

docs: chaining #19

wants to merge 1 commit into from

Conversation

cachho
Copy link
Contributor

@cachho cachho commented Feb 5, 2025

I personally find this syntax much better, especially when using nested validators, like list or record.

But I guess you could also argue that it's a natural part of python and doesn't have to be explained in the docs.

Copy link
Owner

@Naapperas Naapperas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, I just assumed people would naturally do it and didn't even remember to put it on the README but it is in fact something that by all means should be there. Just added a small correction that needs to be made.

Naapperas
Naapperas previously approved these changes Feb 5, 2025
@Naapperas
Copy link
Owner

Great PR. Could you perhaps rebase this branch against develop so we don't pull in that merge commit? Just a nitpick on my end, the PR itself is ready to be merged into develop.

@cachho
Copy link
Contributor Author

cachho commented Feb 12, 2025

Great PR. Could you perhaps rebase this branch against develop so we don't pull in that merge commit? Just a nitpick on my end, the PR itself is ready to be merged into develop.

can you check if that's fine for you? Really not an expert on this.

@Naapperas
Copy link
Owner

Naapperas commented Mar 3, 2025

Great PR. Could you perhaps rebase this branch against develop so we don't pull in that merge commit? Just a nitpick on my end, the PR itself is ready to be merged into develop.

can you check if that's fine for you? Really not an expert on this.

All set for this PR We lost the requested change. If you wish I can take care of it, you'll still get the credit for the work. Note that, with the merging of your latest PR, the README now has conflicts. Shouldn't take much to resolve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants