Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix config.supports to match listentities object #18

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lyuzashi
Copy link

Not sure if you're accepting pull requests, but thanks for taking a look.

I found commands like entity.setBrightness(0.9) were throwing brightness is not supported errors due to a miss-match between the entity config and these setter methods. I've modified the name of each property in the if statements.

supportsBrightness: jspb.Message.getBooleanFieldWithDefault(msg, 5, false),
if (!this.config.supports_brightness) throw new Error('brightness is not supported');

@tobiasgraf
Copy link

I was running into the same issue today and was about to do the same thing, nice PR.

It would be nice if this PR could be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants