fix: eslint pass (#3406)

## Changes - Fix more rules
NangoHQ · Jan 30, 2025 · e34d793 · e34d793
1 parent 64805ae
commit e34d793
Show file tree

Hide file tree

Showing 30 changed files with 52 additions and 57 deletions.
diff --git a/eslint.config.mjs b/eslint.config.mjs
@@ -108,8 +108,6 @@ export default tseslint.config(
             'no-unused-vars': 'off',
             '@typescript-eslint/no-inferrable-types': 'off',
             '@typescript-eslint/require-await': 'error',
-            '@typescript-eslint/no-non-null-assertion': 'warn',
-            '@typescript-eslint/no-explicit-any': 'warn',
 
             '@typescript-eslint/restrict-template-expressions': [
                 'error',
@@ -122,11 +120,11 @@ export default tseslint.config(
 
             '@typescript-eslint/await-thenable': 'error',
             '@typescript-eslint/no-invalid-void-type': 'warn',
-            '@typescript-eslint/no-base-to-string': 'warn',
+            '@typescript-eslint/no-base-to-string': 'error',
             '@typescript-eslint/restrict-plus-operands': 'warn',
             '@typescript-eslint/consistent-type-exports': 'error',
             '@typescript-eslint/no-unnecessary-condition': 'off',
-            '@typescript-eslint/only-throw-error': 'warn',
+            '@typescript-eslint/only-throw-error': 'error',
 
             '@typescript-eslint/no-unused-vars': [
                 'error',
@@ -161,6 +159,8 @@ export default tseslint.config(
             '@typescript-eslint/no-deprecated': 'warn',
             '@typescript-eslint/no-floating-promises': 'warn',
             '@typescript-eslint/no-unsafe-assignment': 'warn',
+            '@typescript-eslint/no-non-null-assertion': 'warn',
+            '@typescript-eslint/no-explicit-any': 'warn',
             '@typescript-eslint/no-unsafe-member-access': 'warn',
             '@typescript-eslint/no-unsafe-call': 'warn',
             '@typescript-eslint/no-unsafe-argument': 'warn',

diff --git a/packages/cli/lib/services/__snapshots__/model.service.unit.test.ts.snap b/packages/cli/lib/services/__snapshots__/model.service.unit.test.ts.snap
@@ -255,9 +255,6 @@ interface RunArgs {
     optionalEnvironment?: string;
     optionalProviderConfigKey?: string;
 }
-export interface DryRunServiceInterface {
-    run: (options: RunArgs, debug?: boolean) => Promise<string | void>;
-}
 export interface NangoProps {
     scriptType: 'sync' | 'action' | 'webhook' | 'on-event';
     host?: string;
@@ -290,7 +287,6 @@ export interface NangoProps {
     rawDeleteOutput?: Map<string, unknown[]> | undefined;
     stubbedMetadata?: Metadata | undefined;
     abortSignal?: AbortSignal;
-    dryRunService?: DryRunServiceInterface;
     syncConfig: DBSyncConfig;
     runnerFlags: RunnerFlags;
     debug: boolean;
@@ -325,7 +321,6 @@ export declare class NangoAction {
     syncJobId?: number;
     dryRun?: boolean;
     abortSignal?: AbortSignal;
-    dryRunService?: DryRunServiceInterface;
     syncConfig?: DBSyncConfig;
     runnerFlags: RunnerFlags;
     connectionId: string;

diff --git a/packages/cli/lib/services/dryrun.service.ts b/packages/cli/lib/services/dryrun.service.ts
@@ -26,8 +26,8 @@ interface RunArgs extends GlobalOptions {
     connectionId: string;
     lastSyncDate?: string;
     useServerLastSyncDate?: boolean;
-    input?: unknown;
-    metadata?: Metadata;
+    input?: string;
+    metadata?: string;
     optionalEnvironment?: string;
     optionalProviderConfigKey?: string;
     saveResponses?: boolean;
@@ -221,8 +221,8 @@ export class DryRunService {
         let normalizedInput;
 
         if (actionInput) {
-            if (actionInput.toString().includes('@') && actionInput.toString().endsWith('.json')) {
-                const fileContents = readFile(actionInput.toString());
+            if (actionInput.startsWith('@') && actionInput.endsWith('.json')) {
+                const fileContents = readFile(actionInput);
                 if (!fileContents) {
                     console.log(chalk.red('The file could not be read. Please make sure it exists.'));
                     return;
@@ -235,9 +235,9 @@ export class DryRunService {
                 }
             } else {
                 try {
-                    normalizedInput = JSON.parse(actionInput as string);
+                    normalizedInput = JSON.parse(actionInput);
                 } catch {
-                    normalizedInput = actionInput;
+                    throw new Error('Failed to parse --input');
                 }
             }
 
@@ -252,8 +252,8 @@ export class DryRunService {
         }
 
         if (rawStubbedMetadata) {
-            if (rawStubbedMetadata.toString().includes('@') && rawStubbedMetadata.toString().endsWith('.json')) {
-                const fileContents = readFile(rawStubbedMetadata.toString());
+            if (rawStubbedMetadata.startsWith('@') && rawStubbedMetadata.endsWith('.json')) {
+                const fileContents = readFile(rawStubbedMetadata);
                 if (!fileContents) {
                     console.log(chalk.red('The metadata file could not be read. Please make sure it exists.'));
                     return;
@@ -266,9 +266,9 @@ export class DryRunService {
                 }
             } else {
                 try {
-                    stubbedMetadata = JSON.parse(rawStubbedMetadata as unknown as string);
+                    stubbedMetadata = JSON.parse(rawStubbedMetadata);
                 } catch {
-                    stubbedMetadata = rawStubbedMetadata;
+                    throw new Error('fail to parse --metadata');
                 }
             }
         }
@@ -340,6 +340,7 @@ export class DryRunService {
                 };
             }
             console.log('---');
+
             const results = await this.runScript({
                 syncName,
                 nangoProps,

diff --git a/packages/cli/lib/services/sdk.ts b/packages/cli/lib/services/sdk.ts
@@ -2,8 +2,9 @@ import { Nango } from '@nangohq/node';
 import type { ProxyConfiguration } from '@nangohq/runner-sdk';
 import { InvalidRecordSDKError, NangoActionBase, NangoSyncBase } from '@nangohq/runner-sdk';
 import type { AdminAxiosProps } from '@nangohq/node';
-import type { DryRunServiceInterface, Metadata, NangoProps, UserLogParameters } from '@nangohq/types';
+import type { Metadata, NangoProps, UserLogParameters } from '@nangohq/types';
 import type { AxiosResponse } from 'axios';
+import type { DryRunService } from './dryrun.service';
 
 const logLevelToLogger = {
     info: 'info',
@@ -17,10 +18,10 @@ const logLevelToLogger = {
 
 export class NangoActionCLI extends NangoActionBase {
     nango: Nango;
-    dryRunService: DryRunServiceInterface;
+    dryRunService: DryRunService;
     dryRun = true;
 
-    constructor(props: NangoProps, cliProps: { dryRunService: DryRunServiceInterface }) {
+    constructor(props: NangoProps, cliProps: { dryRunService: DryRunService }) {
         super(props);
 
         this.dryRunService = cliProps.dryRunService;
@@ -87,7 +88,7 @@ export class NangoActionCLI extends NangoActionBase {
 
 export class NangoSyncCLI extends NangoSyncBase {
     nango: Nango;
-    dryRunService: DryRunServiceInterface;
+    dryRunService: DryRunService;
     dryRun = true;
 
     logMessages: { counts: { updated: number; added: number; deleted: number }; messages: unknown[] } = {
@@ -99,7 +100,7 @@ export class NangoSyncCLI extends NangoSyncBase {
     rawDeleteOutput = new Map<string, unknown[]>();
     stubbedMetadata?: Metadata | undefined = undefined;
 
-    constructor(props: NangoProps, cliProps: { stubbedMetadata?: Metadata | undefined; dryRunService: DryRunServiceInterface }) {
+    constructor(props: NangoProps, cliProps: { stubbedMetadata?: Metadata | undefined; dryRunService: DryRunService }) {
         super(props);
 
         if (cliProps.stubbedMetadata) {

diff --git a/packages/connect-ui/src/lib/api.ts b/packages/connect-ui/src/lib/api.ts
@@ -1,5 +1,4 @@
 /* eslint-disable @typescript-eslint/no-explicit-any */
-/* eslint-disable @typescript-eslint/no-redundant-type-constituents */
 
 import type { ApiError, Endpoint, GetConnectSession, GetPublicListIntegrations, GetPublicProvider } from '@nangohq/types';
 

diff --git a/packages/database/lib/migrations/20240611155149_migrate_external_webhooks_table.cjs b/packages/database/lib/migrations/20240611155149_migrate_external_webhooks_table.cjs
@@ -3,7 +3,6 @@ exports.config = { transaction: false };
 exports.up = async function (knex) {
     let id = 0;
 
-    // eslint-disable-next-line no-constant-condition
     while (true) {
         const environments = await knex.select('*').from('_nango_environments').where('id', '>', id).orderBy('id').limit(100);
 

diff --git a/packages/persist/lib/tracer.ts b/packages/persist/lib/tracer.ts
@@ -11,5 +11,5 @@ tracer.use('elasticsearch', {
 });
 tracer.use('express');
 tracer.use('dns', {
-    enabled: false
+    enabled: true
 });
diff --git a/packages/runner-sdk/models.d.ts b/packages/runner-sdk/models.d.ts
@@ -212,9 +212,6 @@ interface RunArgs {
     optionalEnvironment?: string;
     optionalProviderConfigKey?: string;
 }
-export interface DryRunServiceInterface {
-    run: (options: RunArgs, debug?: boolean) => Promise<string | void>;
-}
 export interface NangoProps {
     scriptType: 'sync' | 'action' | 'webhook' | 'on-event';
     host?: string;
@@ -247,7 +244,6 @@ export interface NangoProps {
     rawDeleteOutput?: Map<string, unknown[]> | undefined;
     stubbedMetadata?: Metadata | undefined;
     abortSignal?: AbortSignal;
-    dryRunService?: DryRunServiceInterface;
     syncConfig: DBSyncConfig;
     runnerFlags: RunnerFlags;
     debug: boolean;
@@ -282,7 +278,6 @@ export declare class NangoAction {
     syncJobId?: number;
     dryRun?: boolean;
     abortSignal?: AbortSignal;
-    dryRunService?: DryRunServiceInterface;
     syncConfig?: DBSyncConfig;
     runnerFlags: RunnerFlags;
     connectionId: string;

diff --git a/packages/runner/lib/idle.ts b/packages/runner/lib/idle.ts
@@ -10,7 +10,7 @@ export async function idle(): Promise<Result<void>> {
     try {
         await retryWithBackoff(
             async () => {
-                return await httpFetch({
+                await httpFetch({
                     method: 'POST',
                     url: `${jobsServiceUrl}/runners/${envs.RUNNER_NODE_ID}/idle`
                 });

diff --git a/packages/runner/lib/register.ts b/packages/runner/lib/register.ts
@@ -13,7 +13,7 @@ export async function register(): Promise<Result<void>> {
     try {
         await retryWithBackoff(
             async () => {
-                return await httpFetch({
+                await httpFetch({
                     method: 'POST',
                     url: `${jobsServiceUrl}/runners/${envs.RUNNER_NODE_ID}/register`,
                     data: JSON.stringify({ url: envs.RUNNER_URL })

diff --git a/packages/scheduler/lib/workers/cleanup/cleanup.worker.ts b/packages/scheduler/lib/workers/cleanup/cleanup.worker.ts
@@ -79,7 +79,7 @@ export class CleanupChild {
 
     async start(): Promise<void> {
         logger.info('Starting cleanup...');
-        // eslint-disable-next-line no-constant-condition
+
         while (!this.cancelled) {
             await this.clean();
             await setTimeout(this.tickIntervalMs);

diff --git a/packages/scheduler/lib/workers/monitor/monitor.worker.ts b/packages/scheduler/lib/workers/monitor/monitor.worker.ts
@@ -78,7 +78,7 @@ export class MonitorChild {
 
     async start(): Promise<void> {
         logger.info('Starting monitor...');
-        // eslint-disable-next-line no-constant-condition
+
         while (!this.cancelled) {
             await this.expires();
             await setTimeout(this.tickIntervalMs);

diff --git a/packages/scheduler/lib/workers/scheduling/scheduling.worker.ts b/packages/scheduler/lib/workers/scheduling/scheduling.worker.ts
@@ -82,7 +82,7 @@ export class SchedulingChild {
 
     async start(): Promise<void> {
         logger.info('Starting scheduling...');
-        // eslint-disable-next-line no-constant-condition
+
         while (!this.cancelled) {
             await this.schedule();
             await setTimeout(this.tickIntervalMs);

diff --git a/packages/server/lib/controllers/v1/connect/sessions/postConnectSessions.ts b/packages/server/lib/controllers/v1/connect/sessions/postConnectSessions.ts
@@ -28,7 +28,7 @@ export const postInternalConnectSessions = asyncWrapper<PostInternalConnectSessi
     const body: PostInternalConnectSessions['Body'] = valBody.data;
 
     // req.body is never but we want to fake it on purpose
-    // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
+
     req.body = {
         allowed_integrations: body.allowed_integrations,
         end_user: body.end_user,

diff --git a/packages/server/lib/refreshConnections.ts b/packages/server/lib/refreshConnections.ts
@@ -54,7 +54,7 @@ export async function exec(): Promise<void> {
 
             let cursor = undefined;
             const limit = 1000;
-            // eslint-disable-next-line no-constant-condition
+
             while (true) {
                 const staleConnections = await connectionService.getStaleConnections({ days: 1, limit, cursor });
                 logger.info(`${cronName} found ${staleConnections.length} stale connections`);

diff --git a/packages/server/lib/webhook/checkr-webhook-routing.ts b/packages/server/lib/webhook/checkr-webhook-routing.ts
@@ -28,6 +28,10 @@ function validate(integration: ProviderConfig, headerSignature: string, rawBody:
 
 const route: WebhookHandler = async (nango, integration, headers, body, rawBody, logContextGetter: LogContextGetter) => {
     const signature = headers['x-checkr-signature'];
+    if (!signature) {
+        logger.error('missing signature', { configId: integration.id });
+        return;
+    }
 
     logger.info('received', { configId: integration.id });
 

diff --git a/packages/server/lib/webhook/hubspot-webhook-routing.unit.test.ts b/packages/server/lib/webhook/hubspot-webhook-routing.unit.test.ts
@@ -96,7 +96,7 @@ describe('Webhook route unit tests', () => {
         const createdHash = crypto.createHash('sha256').update(combinedSignature).digest('hex');
         const headers = { 'x-hubspot-signature': createdHash };
 
-        await HubspotWebhookRouting.default(nangoMock as unknown as Nango, integration as ProviderConfig, headers, body, body.toString(), logContextGetter);
+        await HubspotWebhookRouting.default(nangoMock as unknown as Nango, integration as ProviderConfig, headers, body, '', logContextGetter);
 
         expect(nangoMock.executeScriptForWebhooks).toHaveBeenCalledTimes(body.length);
 
@@ -149,7 +149,7 @@ describe('Webhook route unit tests', () => {
         const createdHash = crypto.createHash('sha256').update(combinedSignature).digest('hex');
         const headers = { 'x-hubspot-signature': createdHash };
 
-        await HubspotWebhookRouting.default(nangoMock as unknown as Nango, integration as ProviderConfig, headers, body, body.toString(), logContextGetter);
+        await HubspotWebhookRouting.default(nangoMock as unknown as Nango, integration as ProviderConfig, headers, body, '', logContextGetter);
 
         expect(nangoMock.executeScriptForWebhooks).toHaveBeenCalledTimes(body.length);
 

diff --git a/packages/server/lib/webhook/internal-nango.ts b/packages/server/lib/webhook/internal-nango.ts
@@ -8,7 +8,7 @@ export interface InternalNango {
     getWebhooks: (environment_id: number, nango_config_id: number) => Promise<SyncConfig[]>;
     executeScriptForWebhooks(
         integration: ProviderConfig,
-        body: any,
+        body: Record<string, any>,
         webhookType: string,
         connectionIdentifier: string,
         logContextGetter: LogContextGetter,

diff --git a/packages/server/lib/webhook/linear-webhook-routing.ts b/packages/server/lib/webhook/linear-webhook-routing.ts
@@ -25,6 +25,10 @@ function validate(integration: ProviderConfig, headerSignature: string, rawBody:
 
 const route: WebhookHandler = async (nango, integration, headers, body, rawBody, logContextGetter: LogContextGetter) => {
     const signature = headers['linear-signature'];
+    if (!signature) {
+        logger.error('missing signature', { configId: integration.id });
+        return;
+    }
 
     logger.info('received', { configId: integration.id });
 

diff --git a/packages/server/lib/webhook/types.ts b/packages/server/lib/webhook/types.ts
@@ -5,7 +5,7 @@ import type { InternalNango } from './internal-nango.js';
 export type WebhookHandler<T = any> = (
     internalNango: InternalNango,
     integration: ProviderConfig,
-    headers: Record<string, any>,
+    headers: Record<string, string>,
     body: T,
     rawBody: string,
     logContextGetter: LogContextGetter

diff --git a/packages/shared/lib/services/connection.service.ts b/packages/shared/lib/services/connection.service.ts
@@ -1197,7 +1197,7 @@ class ConnectionService {
             const { success, error, response: connection } = await this.getConnection(connectionId, providerConfigKey, environmentId);
 
             if (!success || !connection) {
-                throw error;
+                throw error as NangoError;
             }
 
             const shouldRefresh = await this.shouldRefreshCredentials(

diff --git a/packages/shared/lib/utils/error.ts b/packages/shared/lib/utils/error.ts
@@ -337,7 +337,7 @@ export class NangoError extends Error {
 
             case 'generic_error_support':
                 this.status = 500;
-                this.message = 'An error occurred. Please contact support with this unique id: ' + this.payload;
+                this.message = `An error occurred. Please contact support with this unique id: ${JSON.stringify(this.payload)}`;
                 break;
 
             case 'sync_interval_too_short':
@@ -454,7 +454,7 @@ export class NangoError extends Error {
 
             case 'deploy_missing_json_schema_model':
                 this.status = 400;
-                this.message = String(this.payload);
+                this.message = JSON.stringify(this.payload);
                 break;
 
             case 'invalid_action_input':
@@ -504,7 +504,7 @@ export class NangoError extends Error {
 
             case 'wsse_token_generation_error':
                 this.status = 500;
-                this.message = `An error occured while generating an WSSE token`;
+                this.message = `An error occurred while generating an WSSE token`;
                 break;
 
             case 'script_aborted':

diff --git a/packages/types/lib/runner/sdk.ts b/packages/types/lib/runner/sdk.ts
@@ -17,10 +17,6 @@ export interface RunArgs {
     optionalProviderConfigKey?: string;
 }
 
-export interface DryRunServiceInterface {
-    run: (options: RunArgs, debug?: boolean) => Promise<string | void>;
-}
-
 export interface NangoProps {
     scriptType: 'sync' | 'action' | 'webhook' | 'on-event';
     host?: string;

diff --git a/packages/webapp/src/pages/Environment/Settings.tsx b/packages/webapp/src/pages/Environment/Settings.tsx
@@ -308,9 +308,13 @@ export const EnvironmentSettings: React.FC = () => {
         const entries = Array.from(formData.entries());
         for (let i = 0; i < entries.length - 1; i = i + 2) {
             const [[, header], [, value]] = entries.slice(i, i + 2);
+            if (typeof header !== 'string') {
+                continue;
+            }
+
             newOtlpHeaders = {
                 ...newOtlpHeaders,
-                [header.toString()]: value
+                [header]: value
             };
         }
         return newOtlpHeaders;