[NAN-676] enforce cap when activating a script #1953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ers' into khaliq/nan-677-enforce-cap-when-calling-nangoauth
…ers' into khaliq/nan-677-enforce-cap-when-calling-nangoauth
…rect values via the API
…-enforce-cap-when-calling-nangoauth
TBonnin
reviewed
Apr 5, 2024
| @@ -1,2 +1,4 @@ | |||
| export const SYNC_TASK_QUEUE = 'nango-syncs'; | |||
| export const WEBHOOK_TASK_QUEUE = 'nango-webhooks'; | |||
| //export const CONNECTIONS_WITH_SCRIPTS_CAP_LIMIT = 3; | |||
| export const CONNECTIONS_WITH_SCRIPTS_CAP_LIMIT = Infinity; | |||
There was a problem hiding this comment.
Yes, very much so. We don't want to cap until we can set the account information correctly via the API
There was a problem hiding this comment.
Just thought about it during the night (could not sleep). We also have to think about enterprise/community 👌🏻
| setModalOkButtonTitle('Upgrade'); | ||
| setModalCancelButtonTitle('Learn more'); | ||
| setModalOkButtonLink('https://nango.dev/chat'); | ||
| setModalCancelButtonLink('https://docs.nango.dev/REPLACE-ME'); |
There was a problem hiding this comment.
is it going to be replace later?
There was a problem hiding this comment.
Yup, launch blocker to replace.
bodinsamuel
reviewed
Apr 5, 2024
| @@ -990,6 +991,25 @@ class ConnectionService { | |||
| } | |||
| } | |||
|
|
|||
| public async shouldCapUsage({ providerConfigKey, environmentId }: { providerConfigKey: string | undefined; environmentId: number }): Promise<boolean> { | |||
There was a problem hiding this comment.
Can it really be undefined?
There was a problem hiding this comment.
I'll have to look again at it. It probably shouldn't be
TBonnin
approved these changes
Apr 5, 2024
khaliqgant
deleted the
khaliq/nan-676-enforce-cap-when-activating-a-script
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Builds on #1950
Issue ticket number and link
NAN-676
Checklist before requesting a review (skip if just adding/editing APIs & templates)