Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(error): reuse errors definition #1954

Merged
merged 2 commits into from
Apr 5, 2024
Merged

fix(error): reuse errors definition #1954

merged 2 commits into from
Apr 5, 2024

Conversation

bodinsamuel
Copy link
Collaborator

Describe your changes

Contributes to NAN-582

For the logs I need to add a write at all those places but I don't want to declare error a third time

  • Store and reuse error definition where needed

@bodinsamuel bodinsamuel self-assigned this Apr 4, 2024
@linear Linear
Copy link

linear bot commented Apr 4, 2024

NAN-582 Double write

@bodinsamuel bodinsamuel merged commit 2caafb8 into master Apr 5, 2024
19 checks passed
@bodinsamuel bodinsamuel deleted the fix/reuse-wserr branch April 5, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khaliqgant khaliqgant khaliqgant approved these changes

@TBonnin TBonnin Awaiting requested review from TBonnin

Assignees

@bodinsamuel bodinsamuel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bodinsamuel @khaliqgant