Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pagination): [nan-1793] use next_cursor instead of start_cursor #2761

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

khaliqgant
Copy link
Member

Describe your changes

Notion in the response body uses next_cursor

Issue ticket number and link

NAN-1793

Checklist before requesting a review (skip if just adding/editing APIs & templates)

  • I added tests, otherwise the reason is:
  • I added observability, otherwise the reason is:
  • I added analytics, otherwise the reason is:

Copy link

linear bot commented Sep 24, 2024

@khaliqgant khaliqgant merged commit 0f8920c into master Sep 24, 2024
22 checks passed
@khaliqgant khaliqgant deleted the khaliq/nan-1793-fix-notion-pagination branch September 24, 2024 18:06
hassan254-prog pushed a commit that referenced this pull request Sep 25, 2024
…2761)

## Describe your changes
Notion in the response body uses `next_cursor`

## Issue ticket number and link
NAN-1793

## Checklist before requesting a review (skip if just adding/editing
APIs & templates)
- [ ] I added tests, otherwise the reason is: 
- [ ] I added observability, otherwise the reason is:
- [ ] I added analytics, otherwise the reason is:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants