Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Languages #234

Closed
Closed

Conversation

aaronchantrill
Copy link
Contributor

@aaronchantrill aaronchantrill commented Dec 31, 2019

Description

I re-built the translation files. There were so many changes
in 2019 with the new template system for building intents and
the settings built into the plugins directly rather than in
the populate program, that I decided to just start over and
regenerate the translation files from scratch.

I also changed the underlying engine for generating and updating
translation files from pygettext.py (which keeps changing location)
to xgettext, which only requires installing the gettext apt
package.

Almost every set of translations now have some lines that I had
to generate with the help of google translate, so they all need
to be checked for accuracy. I did try to use Rocca Seb's French
and Jan Holthuis' German translations when available.

Related Issue

#224 Translation files need to be updated

Motivation and Context

This change will hopefully allow Naomi to be used by native French and German speakers. Due to the number of changes in the configuration and intent parsing, a lot of the interface was only appearing in English.

How Has This Been Tested?

This has been tested using the unittest system, which didn't report any
new problems. This really needs to be tested by a fluent speaker of French and
a fluent speaker of German. One thing I don't know is how Naomi will react to
umlaut's in the german transcriptions when they are converted to upper case.
This may cause Naomi to not be able to hear or understand certain German
words depending on how the dictionary is set up.

I ended up using Google translate for a lot of the new French and German, so
a lot of stuff probably doesn't sound right to people who speak French and German,
but the .pot files exist now so it should be easy to update those translations.

One interesting question this brings up, though, is how to deal with situations where
there are more valid ways of requesting a service in French or German than in English.
Perhaps it makes more sense to put the French and German templates into their own
files?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

I re-built the translation files. There were so many changes
in 2019 with the new template system for building intents and
the settings built into the plugins directly rather than in
the populate program, that I decided to just start over and
regenerate the translation files from scratch.

I also changed the underlying engine for generating and updating
translation files from pygettext.py (which keeps changing location)
to xgettext, which only requires installing the gettext apt
package.

Almost every set of translations now have some lines that I had
to generate with the help of google translate, so they all need
to be checked for accuracy.
Missing square bracket in wwis_weather.py
Some of the functions in wwis_weather.py were using _ for
gettext, but the assignment was missing.
@aaronchantrill
Copy link
Contributor Author

Just removed the translations from the intents. At this point, I need to do a total redo of the translations anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants