Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I re-built the translation files. There were so many changes
in 2019 with the new template system for building intents and
the settings built into the plugins directly rather than in
the populate program, that I decided to just start over and
regenerate the translation files from scratch.
I also changed the underlying engine for generating and updating
translation files from pygettext.py (which keeps changing location)
to xgettext, which only requires installing the gettext apt
package.
Almost every set of translations now have some lines that I had
to generate with the help of google translate, so they all need
to be checked for accuracy. I did try to use Rocca Seb's French
and Jan Holthuis' German translations when available.
Related Issue
#224 Translation files need to be updated
Motivation and Context
This change will hopefully allow Naomi to be used by native French and German speakers. Due to the number of changes in the configuration and intent parsing, a lot of the interface was only appearing in English.
How Has This Been Tested?
This has been tested using the unittest system, which didn't report any
new problems. This really needs to be tested by a fluent speaker of French and
a fluent speaker of German. One thing I don't know is how Naomi will react to
umlaut's in the german transcriptions when they are converted to upper case.
This may cause Naomi to not be able to hear or understand certain German
words depending on how the dictionary is set up.
I ended up using Google translate for a lot of the new French and German, so
a lot of stuff probably doesn't sound right to people who speak French and German,
but the .pot files exist now so it should be easy to update those translations.
One interesting question this brings up, though, is how to deal with situations where
there are more valid ways of requesting a service in French or German than in English.
Perhaps it makes more sense to put the French and German templates into their own
files?
Screenshots (if appropriate):
Types of changes
Checklist: