Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EstNLTK analyzer #818

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/cicd.yml
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ jobs:
fi
# For Python 3.10:
if [[ ${{ matrix.python-version }} == '3.10' ]]; then
poetry install -E "fasttext spacy";
poetry install -E "fasttext spacy estnltk";
# download the small English pretrained spaCy model needed by spacy analyzer
poetry run python -m spacy download en_core_web_sm --upgrade-strategy only-if-needed
fi
Expand Down
3 changes: 2 additions & 1 deletion annif/analyzer/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
import annif
from annif.util import parse_args

from . import simple, simplemma, snowball, spacy, voikko
from . import estnltk, simple, simplemma, snowball, spacy, voikko

if TYPE_CHECKING:
from annif.analyzer.analyzer import Analyzer
Expand Down Expand Up @@ -42,3 +42,4 @@ def get_analyzer(analyzerspec: str) -> Analyzer:
register_analyzer(simplemma.SimplemmaAnalyzer)
register_analyzer(voikko.VoikkoAnalyzer)
register_analyzer(spacy.SpacyAnalyzer)
register_analyzer(estnltk.EstNLTKAnalyzer)
31 changes: 31 additions & 0 deletions annif/analyzer/estnltk.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
"""EstNLTK analyzer for Annif which uses EstNLTK for lemmatization"""

from __future__ import annotations

import importlib

from . import analyzer


class EstNLTKAnalyzer(analyzer.Analyzer):
name = "estnltk"

@staticmethod
def is_available() -> bool:
# return True iff EstNLTK is installed
return importlib.util.find_spec("estnltk") is not None

def __init__(self, param: str, **kwargs) -> None:
self.param = param
super().__init__(**kwargs)

Check warning on line 20 in annif/analyzer/estnltk.py

View check run for this annotation

Codecov / codecov/patch

annif/analyzer/estnltk.py#L19-L20

Added lines #L19 - L20 were not covered by tests

def tokenize_words(self, text: str, filter: bool = True) -> list[str]:
import estnltk

Check warning on line 23 in annif/analyzer/estnltk.py

View check run for this annotation

Codecov / codecov/patch

annif/analyzer/estnltk.py#L23

Added line #L23 was not covered by tests

txt = estnltk.Text(text.strip())
txt.tag_layer()
return [

Check warning on line 27 in annif/analyzer/estnltk.py

View check run for this annotation

Codecov / codecov/patch

annif/analyzer/estnltk.py#L25-L27

Added lines #L25 - L27 were not covered by tests
lemma
for lemma in [lemmas[0] for lemmas in txt.lemma]
if (not filter or self.is_valid_token(lemma))
]
2 changes: 2 additions & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ huggingface-hub = "~0.25.1"

fasttext-wheel = { version = "0.9.2", optional = true }
voikko = { version = "0.5.*", optional = true }
estnltk = { version = "1.7.3", optional = true }
tensorflow-cpu = { version = "~2.17.0", optional = true }
lmdb = { version = "~1.5.1", optional = true }
omikuji = { version = "0.5.*", optional = true }
Expand All @@ -73,6 +74,7 @@ schemathesis = "3.*.*"
[tool.poetry.extras]
fasttext = ["fasttext-wheel"]
voikko = ["voikko"]
estnltk = ["estnltk"]
nn = ["tensorflow-cpu", "lmdb"]
omikuji = ["omikuji"]
yake = ["yake"]
Expand Down
53 changes: 53 additions & 0 deletions tests/test_analyzer_estnltk.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
"""Unit tests for EstNLTK analyzer in Annif"""

import pytest

import annif.analyzer
import annif.analyzer.estnltk

pytestmark = pytest.mark.skipif(
not annif.analyzer.estnltk.EstNLTKAnalyzer.is_available(),
reason="EstNLTK is required",
)


def test_estnltk_tokenize_words():
analyzer = annif.analyzer.get_analyzer("estnltk")
words = analyzer.tokenize_words(

Check warning on line 16 in tests/test_analyzer_estnltk.py

View check run for this annotation

Codecov / codecov/patch

tests/test_analyzer_estnltk.py#L15-L16

Added lines #L15 - L16 were not covered by tests
"""
Aga kõik juhtus iseenesest. Ka köögis oli kõik endine.
"""
)
assert words == [

Check warning on line 21 in tests/test_analyzer_estnltk.py

View check run for this annotation

Codecov / codecov/patch

tests/test_analyzer_estnltk.py#L21

Added line #L21 was not covered by tests
"aga",
"kõik",
"juhtuma",
"iseenesest",
"köök",
"olema",
"kõik",
"endine",
]


def test_estnltk_tokenize_words_no_filter():
analyzer = annif.analyzer.get_analyzer("estnltk")
words = analyzer.tokenize_words(

Check warning on line 35 in tests/test_analyzer_estnltk.py

View check run for this annotation

Codecov / codecov/patch

tests/test_analyzer_estnltk.py#L34-L35

Added lines #L34 - L35 were not covered by tests
"""
Aga kõik juhtus iseenesest. Ka köögis oli kõik endine.
""",
filter=False,
)
assert words == [

Check warning on line 41 in tests/test_analyzer_estnltk.py

View check run for this annotation

Codecov / codecov/patch

tests/test_analyzer_estnltk.py#L41

Added line #L41 was not covered by tests
"aga",
"kõik",
"juhtuma",
"iseenesest",
".",
"ka",
"köök",
"olema",
"kõik",
"endine",
".",
]