[FINNA-1545] Show all component parts' original languages #3134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EreMaijala
requested changes
Feb 10, 2025
| foreach ($this->stripTrailingPunctuation($this->getFieldArray('979', ['i'])) as $lang) { | ||
| $result[] = $lang; | ||
| foreach ($this->stripTrailingPunctuation($this->getFieldArray('979', ['h', 'i'])) as $lang) { | ||
| $lang = explode(' ', $lang) ?? $lang; |
There was a problem hiding this comment.
explode:n tulos ei voi olla null, vaan se on aina array.
| foreach ($this->stripTrailingPunctuation($this->getFieldArray('979', ['h', 'i'])) as $lang) { | ||
| $lang = explode(' ', $lang) ?? $lang; | ||
| if (is_array($lang)) { | ||
| foreach ($lang as $lng) { |
There was a problem hiding this comment.
Käytä array_merge:ä tai spread operatoria luupin sijaan.
EreMaijala
requested changes
Feb 27, 2025
| @@ -2652,8 +2652,9 @@ public function getOriginalLanguages() | |||
| $result[] = $this->stripTrailingPunctuation($this->getSubfield($field, 'h')) ?? ''; | |||
| } | |||
| } | |||
| foreach ($this->stripTrailingPunctuation($this->getFieldArray('979', ['i'])) as $lang) { | |||
| $result[] = $lang; | |||
| foreach ($this->stripTrailingPunctuation($this->getFieldArray('979', ['h', 'i'])) as $lang) { | |||
There was a problem hiding this comment.
Vasta nyt tuli mieleen, että kannattaa antaa getFieldArray:lle concat-parametriksi false, niin se ei yhdistä osakenttiä, eikä tartte explodea.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.