Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EKIRJASTO-108 Improve contrast in tab bar #76

Closed
wants to merge 6 commits into from
Closed

EKIRJASTO-108 Improve contrast in tab bar #76

wants to merge 6 commits into from

Conversation

natlibfi-ptalosel
Copy link
Contributor

What's this do?

  • User can see the icons and text in the tab bar more easily
    • the contrast was increased in tab bar
    • the selected tab stands out more clearly from the non-selected tabs
  • The appearance of both tab bar item icons and tab bar item titles were updated
    • only color changes were made, such as replacing the green icons with grey ones

Why are we doing this?

  • To improve app's accessibility and visual appearance

How should this be tested?

  • Test E-kirjasto app with device's normal and dark mode

@natlibfi-ptalosel
Copy link
Contributor Author

New PR#78 replaces this PR.

@natlibfi-ptalosel natlibfi-ptalosel deleted the ekirjasto-108-improve-contrast-in-tab-bar branch December 17, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NatLibFi-JoonaKupe NatLibFi-JoonaKupe NatLibFi-JoonaKupe approved these changes

@natlibfi-kaisa natlibfi-kaisa natlibfi-kaisa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@natlibfi-ptalosel @NatLibFi-JoonaKupe @natlibfi-kaisa