Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/upgrade GitHub actions stark12 #3957

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

SuperITMan
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[X] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

GH Workflow is using a deprecated action (upload-artifact@v2) which is deprecated.
More details on: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

The "main" NodeJS version is 18 but we use internally NodeJS 20 to build Stark.

Issue Number: N/A

What is the new behavior?

GH Actions in all workflows are up-to-date.

The main NodeJS version is now 20 and we execute tests on NodeJS 22 also.
Finally, we now depend on the latest [email protected] instead of fixed [email protected].

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

@SuperITMan SuperITMan added comp: ci & tooling CI, GitHub Actions, ... 12.x Stark version github_actions Pull requests that update GitHub Actions code labels Nov 6, 2024
@SuperITMan SuperITMan added this to the 12.1.0 milestone Nov 6, 2024
@SuperITMan SuperITMan requested a review from mhenkens November 6, 2024 20:08
@coveralls
Copy link

coveralls commented Nov 6, 2024

Coverage Status

coverage: 88.856%. remained the same
when pulling f8b8161 on SuperITMan:feature/upgrade-github-actions-stark12
into f720352 on NationalBankBelgium:master.

@SuperITMan SuperITMan force-pushed the feature/upgrade-github-actions-stark12 branch from 45f1c42 to f8b8161 Compare November 6, 2024 20:25
Copy link

sonarcloud bot commented Nov 6, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
12.x Stark version comp: ci & tooling CI, GitHub Actions, ... github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants