deprecate IBaseDataObjectHelper.clone() that allows partial clones. (#…

…1018)

src/main/java/emissary/core/IBaseDataObjectHelper.java

@@ -37,15 +37,27 @@ private InternalIdBaseDataObject(final UUID internalId) {
 
     private IBaseDataObjectHelper() {}
 
+    /**
+     * Clones an IBaseDataObject.
+     * 
+     * @param iBaseDataObject the IBaseDataObject to be cloned.
+     * @return the clone of the IBaseDataObject passed in.
+     */
+    public static IBaseDataObject clone(final IBaseDataObject iBaseDataObject) {
+        return clone(iBaseDataObject, true);
+    }
+
     /**
      * Clones an IBaseDataObject equivalently to emissary.core.BaseDataObject.clone(), which duplicates some attributes.
      * 
      * A "fullClone" duplicates all attributes.
      * 
+     * @deprecated prefer {@link #clone(IBaseDataObject)}
      * @param iBaseDataObject the IBaseDataObject to be cloned.
      * @param fullClone specifies if all fields should be cloned.
      * @return the clone of the IBaseDataObject passed in.
      */
+    @Deprecated
     public static IBaseDataObject clone(final IBaseDataObject iBaseDataObject, final boolean fullClone) {
         Validate.notNull(iBaseDataObject, "Required: iBaseDataObject not null");
 

src/test/java/emissary/core/IBaseDataObjectHelperTest.java

@@ -108,6 +108,19 @@ private static void verifyCloneAssertions(final Method method, final Object obj1
 
     }
 
+    @Test
+    void testOneArgClone() {
+        final IBaseDataObject originalIbdo = new BaseDataObject(new byte[123], "Filename", "form", "filetype");
+        final IBaseDataObject clonedIbdo = IBaseDataObjectHelper.clone(originalIbdo);
+        final List<String> differences = new ArrayList<>();
+        final DiffCheckConfiguration diffCheckConfiguration =
+                DiffCheckConfiguration.configure().enableData().enableInternalId().enableTimestamp().enableTransformHistory().build();
+
+        IBaseDataObjectDiffHelper.diff(originalIbdo, clonedIbdo, differences, diffCheckConfiguration);
+
+        assertEquals(0, differences.size());
+    }
+
     @Test
     void testCloneArguments() {
         assertNotNull(IBaseDataObjectHelper.clone(new BaseDataObject(), false));