errorprone :: NonFinalStaticField (#810)

src/main/java/emissary/core/Namespace.java

@@ -28,7 +28,7 @@ public class Namespace {
     private static final Logger logger = LoggerFactory.getLogger(Namespace.class);
 
     /** We will hold registerd class names in here */
-    private static Map<String, Object> map = new ConcurrentHashMap<>();
+    private static final Map<String, Object> map = new ConcurrentHashMap<>();
 
     /**
      * Hide the creation a new instance of NameSpace

src/main/java/emissary/directory/EmissaryNode.java

@@ -37,7 +37,7 @@
  * </ol>
  */
 public class EmissaryNode {
-    private static Logger logger = LoggerFactory.getLogger(EmissaryNode.class);
+    private static final Logger logger = LoggerFactory.getLogger(EmissaryNode.class);
 
     /** Node name property is {@value} */
     public static final String NODE_NAME_PROPERTY = "emissary.node.name";

src/main/java/emissary/util/JavaCharSet.java

@@ -11,7 +11,7 @@
  */
 public class JavaCharSet {
 
-    private static Map<String, String> charsets = new HashMap<>();
+    private static final Map<String, String> charsets = new HashMap<>();
 
     private static boolean initialized = false;
 

src/main/java/emissary/util/SizeUtil.java

@@ -26,7 +26,7 @@ public class SizeUtil {
     /**
      * Object overhead
      */
-    private static long objOverhead = 8L;
+    private static final long objOverhead = 8L;
 
     static {
         if (System.getProperty("os.arch").contains("64")) {

src/main/java/emissary/util/UnixFile.java

@@ -14,7 +14,7 @@
 
 public class UnixFile {
 
-    private static Logger log = LoggerFactory.getLogger(UnixFile.class);
+    private static final Logger log = LoggerFactory.getLogger(UnixFile.class);
 
     /** The magic number configuration file. The file which contains all magic number entries */
     private List<File> magicFiles = new ArrayList<>();

src/main/java/emissary/util/search/FastBoyerMoore.java

@@ -10,7 +10,7 @@
 import javax.annotation.Nullable;
 
 public class FastBoyerMoore {
-    private static Logger logger = LoggerFactory.getLogger(FastBoyerMoore.class);
+    private static final Logger logger = LoggerFactory.getLogger(FastBoyerMoore.class);
     public byte[][] keywords;
     int minKeywordLength;
     int[] lookup = new int[259];

src/test/java/emissary/output/roller/journal/JournaledChannelTest.java

@@ -22,18 +22,14 @@
 
 class JournaledChannelTest extends UnitTest {
 
-    @Nullable
-    @TempDir
-    private static Path TEMP_DIR = null;
     @Nullable
     private JournaledChannel channel;
     private String onekstring = "";
 
     @BeforeEach
-    @Override
-    public void setUp() throws Exception {
+    public void setUp(@TempDir final Path tmpDir) throws Exception {
         super.setUp();
-        this.channel = new JournaledChannel(TEMP_DIR.resolve(UUID.randomUUID().toString()), "unittest", 0);
+        this.channel = new JournaledChannel(tmpDir.resolve(UUID.randomUUID().toString()), "unittest", 0);
         StringBuilder sb = new StringBuilder();
         for (int i = 0; i < 1024; i++) {
             sb.append(i % 10);