Added a ResourceReader that can retrieve test resource files in nested locations #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s that aren't tightly coupled to the default file naming schemes
drivenflywheel
force-pushed
the
GreedyResourceReader
branch
from
f37d147
to
432688e
Compare
|
@drivenflywheel is this something we should revisit or spend cycles integrating? It seems helpful for certain situations but I'm not sure where we left it. |
dev-mlb
reviewed
Sep 25, 2024
| * content-representative file names. | ||
| * </p> | ||
| */ | ||
| public class GreedyResourceReader extends ResourceReader { |
There was a problem hiding this comment.
Should this class exist in the test package?
There was a problem hiding this comment.
You could argue either way, but I like it where it is. As a class that supports a test (as opposed to containing tests), it seems reasonable to be in main/util/io.
|
As a newer user of the API, I like the idea of not have to call everything a .dat file in tests. As a follow-on effort, it might be good to incorporate this into RegressionTest and it's generation of answer files to follow this implementation. |
DonResnik
approved these changes
Oct 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows decoupling from the default ".dat" file naming scheme and flat directory structure. Primarily intended for use by IdentificationTests that can benefit from more content-representative test file names. Along with PR #555, this will allow IdentificationTests to specify a payload's "expected form" via directory name rather than file name, without explicitly requiring an answer XML file.
With the initial commit, test data files should be stored anywhere below the TestClassName/payloads folder. Answer files (when needed) should be in mirrored paths below the TestClassName/answers folder.
Given the fairly large break with existing convention, I thought it would be prudent to keep this functionality out of the base
ResourceReaderclass so devs would not accidentally select the new methods via autocomplete.