-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modified KffDataObjectHandler.hash(..) method so it explicitly replaces IBDO params it generates. #596
Modified KffDataObjectHandler.hash(..) method so it explicitly replaces IBDO params it generates. #596
Conversation
…es IBDO params it generates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebased and observed the following errors:
[ERROR] IBaseDataObjectDiffHelperTest.testDiffCurrentForm:137 » ExceptionInInitializer
[ERROR] UnixFilePlaceTest>IdentificationTest.testIdentificationPlace:61 » java.lang.reflect.InvocationTargetException
[ERROR] KffDataObjectHandlerTest.setUp:60 » java.lang.reflect.InvocationTargetException
[ERROR] KffHashPlaceTest.testProcess:24 » IllegalState No config directory specified
Run it again. That's an intermittent-but-recurring issue unrelated to this change. Since the order of unit test execution is randomized, it might indicate that the codebase has one or more unit test classes that don't extend Emissary's |
Ugh...I thought I had gotten all of those at one point. This should fix it: #597 |
A given object should have only one value for each type of hash we compute. With this change, the last one computed wins. Need to make sure that's the behavior we want.
Honestly, we should probably instead modify the behavior so that the
hash
method hashes a given payload at-most one time (so the computed hashes represent the data in its original form), with any subsequent calls being no-op'ed.