Using FILE_ABSOLUTEPATH and Original-Filename to populate FILEXT #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drivenflywheel
requested changes
Oct 2, 2023
drivenflywheel
requested changes
Oct 12, 2023
drivenflywheel
previously approved these changes
Oct 13, 2023
fbruton
requested changes
Oct 14, 2023
fbruton
requested changes
Oct 20, 2023
fbruton
approved these changes
Oct 27, 2023
drivenflywheel
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifying DropOffUtil.extractUniqueFileExtensions() to support full file paths and adding FILE_ABSOLUTEPATH as a field to look in to populate the FILEXT field on the IBDO. The existing behavior only used the Original-Filename field to populate FILEXT.
As part of this change, I also added a static method DropOffUtil.getBestFilenames() that looks at the IBDO in the FILE_ABSOLUTEPATH and Original-Filename fields and returns all values found in both of those fields.