Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add megalinter instructions to DEVELOPING.md and move settings to separate file #607

Merged
merged 6 commits into from
Dec 28, 2023

Conversation

cfkoehler
Copy link
Collaborator

No description provided.

.mega-linter.yml Outdated Show resolved Hide resolved
@cfkoehler cfkoehler changed the title Add meaglint instructions to DEVELOPING.md and move settings to separate file Add megalinter instructions to DEVELOPING.md and move settings to separate file Oct 5, 2023
@cfkoehler cfkoehler marked this pull request as ready for review October 14, 2023 10:14
@jpdahlke jpdahlke added this to the v8.0.0-M11 milestone Dec 12, 2023
@jpdahlke jpdahlke added the CI/CD Changes to the CI/CD Pipeline label Dec 12, 2023
jpdahlke
jpdahlke previously approved these changes Dec 15, 2023
@jpdahlke jpdahlke modified the milestones: v8.0.0-M11, v8.0.0-M12 Dec 15, 2023
@jpdahlke jpdahlke requested a review from a user December 21, 2023 21:37
ghost
ghost previously requested changes Dec 26, 2023
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than some language I found confusing in DEVELOPING.md, everything looks good to me!

DEVELOPING.md Outdated Show resolved Hide resolved
DEVELOPING.md Outdated Show resolved Hide resolved
DEVELOPING.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@fbruton fbruton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix minor typo

Co-authored-by: fbruton <[email protected]>
@jpdahlke jpdahlke requested a review from fbruton December 27, 2023 22:04
@jpdahlke jpdahlke dismissed stale reviews from ghost and fbruton December 27, 2023 22:05

updates made

@jpdahlke jpdahlke merged commit 321d724 into NationalSecurityAgency:master Dec 28, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Changes to the CI/CD Pipeline
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants